Add image button action support

codemagic-ci-cd · Jan 6, 2024 · c6a3cad · c6a3cad
1 parent a2d80e7
commit c6a3cad
Show file tree

Hide file tree

Showing 5 changed files with 43 additions and 3 deletions.
diff --git a/...ditors/Source Editor/Formatter Extensions/WKSourceEditorFormatterLink+ButtonActions.swift b/...ditors/Source Editor/Formatter Extensions/WKSourceEditorFormatterLink+ButtonActions.swift
@@ -98,4 +98,13 @@ extension WKSourceEditorFormatterLink {
             }
         }
     }
+
+    func insertImage(wikitext: String, in textView: UITextView) {
+
+        guard let selectedTextRange = textView.selectedTextRange else {
+            return
+        }
+
+        textView.replace(selectedTextRange, withText: wikitext)
+    }
 }
diff --git a/...ts/Sources/Components/Components/Editors/Source Editor/WKSourceEditorViewController.swift b/...ts/Sources/Components/Components/Editors/Source Editor/WKSourceEditorViewController.swift
@@ -5,6 +5,7 @@ public protocol WKSourceEditorViewControllerDelegate: AnyObject {
     func sourceEditorViewControllerDidTapFind(sourceEditorViewController: WKSourceEditorViewController)
     func sourceEditorViewControllerDidRemoveFindInputAccessoryView(sourceEditorViewController: WKSourceEditorViewController)
     func sourceEditorViewControllerDidTapLink(parameters: WKSourceEditorFormatterLinkWizardParameters)
+    func sourceEditorViewControllerDidTapImage()
 }
 
 // MARK: NSNotification Names
@@ -266,6 +267,10 @@ public class WKSourceEditorViewController: WKComponentViewController {
 
         self.preselectedTextRange = nil
     }
+
+    public func insertImage(wikitext: String) {
+        textFrameworkMediator.linkFormatter?.insertImage(wikitext: wikitext, in: textView)
+    }
 }
 
 // MARK: - Private
@@ -364,7 +369,7 @@ extension WKSourceEditorViewController: WKEditorToolbarExpandingViewDelegate {
     }
 
     func toolbarExpandingViewDidTapImage(toolbarView: WKEditorToolbarExpandingView) {
-
+        delegate?.sourceEditorViewControllerDidTapImage()
     }
 }
 

diff --git a/Wikipedia/Code/InsertMediaViewController.swift b/Wikipedia/Code/InsertMediaViewController.swift
@@ -130,8 +130,7 @@ final class InsertMediaViewController: ViewController {
             switch (mediaSettings.caption, mediaSettings.alternativeText) {
             case (let caption?, let alternativeText?):
                 wikitext = """
-                [[\(searchResult.fileTitle) | \(mediaSettings.advanced.imageType.rawValue) | \(mediaSettings.advanced.imageSize.rawValue) | \(mediaSettings.advanced.imagePosition.rawValue) | alt= \(alternativeText) |
-                \(caption)]]
+                [[\(searchResult.fileTitle) | \(mediaSettings.advanced.imageType.rawValue) | \(mediaSettings.advanced.imageSize.rawValue) | \(mediaSettings.advanced.imagePosition.rawValue) | alt= \(alternativeText) | \(caption)]]
                 """
             case (let caption?, nil):
                 wikitext = """

diff --git a/Wikipedia/Code/PageEditorViewController.swift b/Wikipedia/Code/PageEditorViewController.swift
@@ -233,6 +233,7 @@ extension PageEditorViewController: Themeable {
 // MARK: - WKSourceEditorViewControllerDelegate
 
 extension PageEditorViewController: WKSourceEditorViewControllerDelegate {
+
     func sourceEditorViewControllerDidTapFind(sourceEditorViewController: WKSourceEditorViewController) {
         showFocusNavigationView()
     }
@@ -273,6 +274,15 @@ extension PageEditorViewController: WKSourceEditorViewControllerDelegate {
             present(navigationController, animated: true)
         }
     }
+
+    func sourceEditorViewControllerDidTapImage() {
+        let insertMediaViewController = InsertMediaViewController(articleTitle: pageURL.wmf_title, siteURL: pageURL.wmf_site)
+        insertMediaViewController.delegate = self
+        insertMediaViewController.apply(theme: theme)
+        let navigationController = WMFThemeableNavigationController(rootViewController: insertMediaViewController, theme: theme)
+        navigationController.isNavigationBarHidden = true
+        present(navigationController, animated: true)
+    }
 }
 
 // MARK: - PageEditorNavigationItemControllerDelegate
@@ -384,6 +394,19 @@ extension PageEditorViewController: InsertLinkViewControllerDelegate {
     }
 }
 
+// MARK: - Insert
+
+extension PageEditorViewController: InsertMediaViewControllerDelegate {
+    func insertMediaViewController(_ insertMediaViewController: InsertMediaViewController, didTapCloseButton button: UIBarButtonItem) {
+        dismiss(animated: true)
+    }
+
+    func insertMediaViewController(_ insertMediaViewController: InsertMediaViewController, didPrepareWikitextToInsert wikitext: String) {
+        sourceEditor.insertImage(wikitext: wikitext)
+        dismiss(animated: true)
+    }
+}
+
 enum SourceEditorAccessibilityIdentifiers: String {
     case entryButton = "Source Editor Entry Button"
     case textView = "Source Editor TextView"

diff --git a/WikipediaUITests/UITestHelperViewController.swift b/WikipediaUITests/UITestHelperViewController.swift
@@ -154,6 +154,10 @@ public class UITestHelperViewController: WKCanvasViewController {
 
 
 extension UITestHelperViewController: WKSourceEditorViewControllerDelegate {
+    public func sourceEditorViewControllerDidTapImage() {
+
+    }
+
     public func sourceEditorViewControllerDidTapLink(parameters: Components.WKSourceEditorFormatterLinkWizardParameters) {
 
     }
-Original file line number
+Diff line change
@@ Expand Up @@
     extension UITestHelperViewController: WKSourceEditorViewControllerDelegate {
+        public func sourceEditorViewControllerDidTapImage() {
+        }
         public func sourceEditorViewControllerDidTapLink(parameters: Components.WKSourceEditorFormatterLinkWizardParameters) {
         }
@@ Expand Down @@