Merge pull request wikimedia#3943 from wikimedia/T282189

Loosen AaaLD test/control assignment survey identifiers
codemagic-ci-cd · May 11, 2021 · 3c00909 · 3c00909
2 parents 8f30c8d + 01c1d61
commit 3c00909
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/WMF Framework/SurveyAnnouncementsController.swift b/WMF Framework/SurveyAnnouncementsController.swift
@@ -37,7 +37,7 @@ public final class SurveyAnnouncementsController: NSObject {
 
         //assign and persist ab test bucket &  percentage
         //this works for now since we only have one experiment for this release but will likely need to change as we expand
-        if let articleAsLivingDocAnnouncement = surveyAnnouncements.first(where: { $0.identifier == "IOSSURVEY20IOSV4EN" }),
+        if let articleAsLivingDocAnnouncement = surveyAnnouncements.first(where: { ($0.identifier?.hasPrefix("IOSAAALDSURVEY")) ?? false }),
            let percentage = articleAsLivingDocAnnouncement.percentReceivingExperiment {
 
             do {

diff --git a/WMF Framework/WMFAnnouncementsFetcher.m b/WMF Framework/WMFAnnouncementsFetcher.m
@@ -79,7 +79,7 @@ - (void)fetchAnnouncementsForURL:(NSURL *)siteURL force:(BOOL)force failure:(WMF
         if (![obj isKindOfClass:[WMFAnnouncement class]]) {
             return NO;
         }
-        if ([obj.platforms containsObject:@"iOSAppV4"]) {
+        if ([obj.platforms containsObject:@"iOSAppV5"]) {
             return YES;
         } else {
             return NO;