Failed check and status messaging in comment, part II #1023

nora-codecov · 2025-01-22T00:49:17Z

when user has:
patch checks notifier OR patch status notifier
AND
comment notifier
AND
has defined a target in their codecov yml
AND
the patch check/status fails
THEN
add some helper text to the comment notifier to point out that the check/status failed and that they can change their target.

codecov/engineering-team#1626

github-actions · 2025-01-22T00:58:41Z

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

giovanni-guidini

LGTM

giovanni-guidini · 2025-01-22T09:11:03Z

codecov.yml

@@ -7,7 +7,7 @@ component_management:
  default_rules:
    statuses:
      - type: project
-        target: auto
+        target: 99


Was this for testing? Do we want to leave it like so?

i wanted to trigger the help text im adding in this pr, but i changed this in a separate commit after the first pr comment already happened, so i think the comment didn't update with my helper text. I'll manipulate it some more...

giovanni-guidini · 2025-01-22T09:13:38Z

services/notification/notifiers/mixins/message/__init__.py

-            owner.plan == BillingPlan.team_monthly.value
-            or owner.plan == BillingPlan.team_yearly.value
-        ):
+        owner_plan = PlanService(owner)


codecov-qa · 2025-01-22T21:36:59Z

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
1	1	0	0

View the top 1 failed tests by shortest run time

services/notification/tests/unit/test_notification_service.py::services.notification.tests.unit.test_notification_service

Stack Traces | 0s run time

.../tests/unit/test_notification_service.py:52: in <module>
    class TestNotificationService(object):
.../tests/unit/test_notification_service.py:215: in TestNotificationService
    [GITHUB_APP_INSTALLATION_DEFAULT_NAME, "notifications-app"],
E   NameError: name 'GITHUB_APP_INSTALLATION_DEFAULT_NAME' is not defined

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

codecov-public-qa · 2025-01-22T21:37:07Z

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
1	1	0	0

View the top 1 failed tests by shortest run time

services/notification/tests/unit/test_notification_service.py::::services.notification.tests.unit.test_notification_service

Stack Traces | 0s run time

No failure message available

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

codecov · 2025-01-22T23:39:18Z

Codecov Report

Attention: Patch coverage is 98.91304% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.71%. Comparing base (254374e) to head (bcef3bc).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...ification/notifiers/checks/checks_with_fallback.py	80.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1023   +/-   ##
=======================================
  Coverage   97.71%   97.71%           
=======================================
  Files         458      458           
  Lines       37072    37138   +66     
=======================================
+ Hits        36224    36289   +65     
- Misses        848      849    +1

Flag	Coverage Δ
integration	`42.55% <41.30%> (-0.04%)`	⬇️
unit	`90.29% <98.91%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

⚠️ Impact Analysis from Codecov is deprecated and will be sunset on Jan 31 2025. See more

codecov-notifications · 2025-01-22T23:42:20Z

Codecov Report

Attention: Patch coverage is 98.91304% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...ification/notifiers/checks/checks_with_fallback.py	80.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

…o other notifiers

…user has defined a `target`

sentry-io · 2025-01-23T22:55:43Z

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

‼️ KeyError: 'layout' app.tasks.notify.Notify View Issue
‼️ IntegrityError: (psycopg2.errors.UniqueViolation) duplicate key value violates unique constraint "commit_notifica... app.tasks.notify.Notify View Issue
‼️ IndexError: list index out of range app.tasks.notify.Notify View Issue
‼️ AttributeError: 'NoneType' object has no attribute 'repoid' app.tasks.notify.Notify View Issue
‼️ ValueError: Unsupported plan app.tasks.notify.Notify View Issue

_{Did you find this useful? React with a 👍 or 👎}

nora-codecov requested a review from a team January 22, 2025 00:49

nora-codecov changed the title ~~add helper text to PR comment~~ Failed check and status messaging in comment, part II Jan 22, 2025

nora-codecov force-pushed the nora/1626-target-text branch from 9dc9f9b to b7348ce Compare January 22, 2025 00:51

giovanni-guidini approved these changes Jan 22, 2025

View reviewed changes

Swatinem approved these changes Jan 22, 2025

View reviewed changes

nora-codecov temporarily deployed to staging January 22, 2025 18:24 — with GitHub Actions Inactive

nora-codecov force-pushed the nora/1626 branch from 9d9d277 to 07be913 Compare January 22, 2025 19:41

nora-codecov force-pushed the nora/1626-target-text branch from 5140b65 to 283a406 Compare January 22, 2025 21:32

codecov deleted a comment from codecov bot Jan 22, 2025

codecov deleted a comment from codecov-notifications bot Jan 22, 2025

nora-codecov force-pushed the nora/1626 branch from 7c99a5a to 9634837 Compare January 23, 2025 21:41

nora-codecov force-pushed the nora/1626-target-text branch from 55997ae to 94a506d Compare January 23, 2025 21:52

nora-codecov changed the base branch from nora/1626 to main January 23, 2025 21:59

nora-codecov added 6 commits January 23, 2025 14:13

outline

0ec28a1

build out types for status and checks, for passing information back t…

946cd7f

…o other notifiers

temp changes to tests and codecov yml

5d743bb

add patch status with target

9e6377e

undo temp changes for message testing

45d6a21

add helper text to PR comment for failed patch status or checks when …

bcef3bc

…user has defined a `target`

nora-codecov force-pushed the nora/1626-target-text branch from 94a506d to bcef3bc Compare January 23, 2025 22:16

nora-codecov added this pull request to the merge queue Jan 23, 2025

Merged via the queue into main with commit e3229e5 Jan 23, 2025
26 of 27 checks passed

nora-codecov deleted the nora/1626-target-text branch January 23, 2025 22:33

nora-codecov mentioned this pull request Jan 24, 2025

Failed check and status messaging in comment, part III #1030

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Failed check and status messaging in comment, part II #1023

Failed check and status messaging in comment, part II #1023

nora-codecov commented Jan 22, 2025

github-actions bot commented Jan 22, 2025 •

edited

Loading

giovanni-guidini left a comment

giovanni-guidini Jan 22, 2025

nora-codecov Jan 22, 2025

giovanni-guidini Jan 22, 2025

codecov-qa bot commented Jan 22, 2025

codecov-public-qa bot commented Jan 22, 2025

codecov bot commented Jan 22, 2025 •

edited

Loading

codecov-notifications bot commented Jan 22, 2025 •

edited

Loading

sentry-io bot commented Jan 23, 2025 •

edited

Loading

Failed check and status messaging in comment, part II #1023

Failed check and status messaging in comment, part II #1023

Conversation

nora-codecov commented Jan 22, 2025

github-actions bot commented Jan 22, 2025 • edited Loading

giovanni-guidini left a comment

Choose a reason for hiding this comment

giovanni-guidini Jan 22, 2025

Choose a reason for hiding this comment

nora-codecov Jan 22, 2025

Choose a reason for hiding this comment

giovanni-guidini Jan 22, 2025

Choose a reason for hiding this comment

codecov-qa bot commented Jan 22, 2025

❌ 1 Tests Failed:

codecov-public-qa bot commented Jan 22, 2025

❌ 1 Tests Failed:

codecov bot commented Jan 22, 2025 • edited Loading

Codecov Report

codecov-notifications bot commented Jan 22, 2025 • edited Loading

Codecov Report

sentry-io bot commented Jan 23, 2025 • edited Loading

Suspect Issues

github-actions bot commented Jan 22, 2025 •

edited

Loading

codecov bot commented Jan 22, 2025 •

edited

Loading

codecov-notifications bot commented Jan 22, 2025 •

edited

Loading

sentry-io bot commented Jan 23, 2025 •

edited

Loading