Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Failed check and status messaging in comment, part I" #1021

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

nora-codecov
Copy link
Contributor

Reverts #1014

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.27%. Comparing base (369a74b) to head (ac5b00a).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
services/notification/notifiers/status/patch.py 83.33% 1 Missing ⚠️
tasks/tests/integration/test_notify_task.py 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (369a74b) and HEAD (ac5b00a). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (369a74b) HEAD (ac5b00a)
unit 2 1
integration 2 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1021      +/-   ##
==========================================
- Coverage   97.73%   90.27%   -7.46%     
==========================================
  Files         451      451              
  Lines       36972    36922      -50     
==========================================
- Hits        36135    33333    -2802     
- Misses        837     3589    +2752     
Flag Coverage Δ
integration ?
unit 90.27% <90.47%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

⚠️ Impact Analysis from Codecov is deprecated and will be sunset on Jan 31 2025. See more

Copy link

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@nora-codecov nora-codecov added this pull request to the merge queue Jan 21, 2025
@codecov-notifications
Copy link

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
services/notification/notifiers/status/patch.py 83.33% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Merged via the queue into main with commit f90b831 Jan 21, 2025
19 of 27 checks passed
@nora-codecov nora-codecov deleted the revert-1014-nora/1626 branch January 21, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants