fix: Add size classname prop for modal #3674
Conversation
Bundle ReportChanges will increase total bundle size by 12.15MB (100.0%) ⬆️
|
Bundle ReportChanges will increase total bundle size by 44 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3674 +/- ##
=======================================
Coverage 98.80% 98.80%
=======================================
Files 820 820
Lines 14784 14784
Branches 4214 4214
=======================================
Hits 14608 14608
Misses 167 167
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3674 +/- ##
=======================================
Coverage 98.80% 98.80%
=======================================
Files 820 820
Lines 14784 14784
Branches 4206 4206
=======================================
Hits 14608 14608
Misses 167 167
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3674 +/- ##
=======================================
Coverage 98.80% 98.80%
=======================================
Files 820 820
Lines 14784 14784
Branches 4206 4206
=======================================
Hits 14608 14608
Misses 167 167
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3674 +/- ##
=======================================
Coverage 98.80% 98.80%
=======================================
Files 820 820
Lines 14784 14784
Branches 4214 4214
=======================================
Hits 14608 14608
Misses 167 167
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Description
Adding an optional classname prop for the size of a modal to allow possible extra styles such as max width. Currently, on large screens, the designated width is 50% which can be much wider than needed, especially if the modal also has vertical scrolling as our BaseModal element right now has a max height of `m-h-96' designated. We could add this prop and/or add default max dimension styling if we desire.
Code Example
Notable Changes
Screenshots
Existing situation that is super wide where a single text line doesn't even reach the halfway point of the modal:
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.