chore: Clean up bundle caching feature flag #3659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3659 +/- ##
==========================================
+ Coverage 98.81% 98.83% +0.01%
==========================================
Files 825 825
Lines 14892 14886 -6
Branches 4233 4237 +4
==========================================
- Hits 14716 14712 -4
+ Misses 167 165 -2
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3659 +/- ##
==========================================
+ Coverage 98.81% 98.83% +0.01%
==========================================
Files 825 825
Lines 14892 14886 -6
Branches 4233 4229 -4
==========================================
- Hits 14716 14712 -4
+ Misses 167 165 -2
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will decrease total bundle size by 307 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3659 +/- ##
==========================================
+ Coverage 98.93% 98.94% +0.01%
==========================================
Files 815 815
Lines 14686 14680 -6
Branches 4168 4156 -12
==========================================
- Hits 14529 14525 -4
+ Misses 150 148 -2
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3659 +/- ##
==========================================
+ Coverage 98.81% 98.83% +0.01%
==========================================
Files 825 825
Lines 14892 14886 -6
Branches 4233 4237 +4
==========================================
- Hits 14716 14712 -4
+ Misses 167 165 -2
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
calvin-codecov
approved these changes
Jan 15, 2025
nicholas-codecov
force-pushed
the
gh-eng-3157-chore-clean-up-bundle-caching-feature-flag
branch
from
26beebf to
8b646bc
Compare
Bundle ReportChanges will decrease total bundle size by 307 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-staging-systemAssets Changed:
Files in
Files in
view changes for bundle: gazebo-staging-esmAssets Changed:
Files in
Files in
|
nicholas-codecov
deleted the
gh-eng-3157-chore-clean-up-bundle-caching-feature-flag
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR just removes the
displayBundleCachingModalfrom the codebase cleaning up things once everything has been fully released.Closes codecov/engineering-team#3157
Notable Changes
BundleSelectionandConfigurationManager