Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added appropriate message for filter #1725 #1728

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Added appropriate message for filter #1725 #1728

merged 2 commits into from
Jan 29, 2025

Conversation

Vinit1014
Copy link
Contributor

@Vinit1014 Vinit1014 commented Jan 29, 2025 •
edited
Loading

PR Fixes:

  • 1 A short and simple message displayed when filtered content is null to make a better user experience.
  • 2 Displays different message for different filter.

Resolves #1725

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue
    Screenshot 2025-01-29 143849
    Screenshot 2025-01-29 143913

devsargam
devsargam requested changes Jan 29, 2025
View reviewed changes
@devsargam
Copy link
Collaborator

Thank you appreciate it

@devsargam devsargam merged commit a7ed763 into code100x:main Jan 29, 2025
@Vinit1014
Copy link
Contributor Author

Welcome sir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsargam devsargam devsargam requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature: Proper display of message in UI when any filter result is null
2 participants
@Vinit1014 @devsargam