Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(test-utils): disable GPG sign for commit/tag utility #905

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

vmasek
Copy link
Collaborator

@vmasek vmasek commented Dec 25, 2024

I've recently added a GPG signature to my commits and that broke running the integration tests locally for me 😅 this is fixing it

@github-actions github-actions bot added the 🔬 testing writing tests label Dec 25, 2024
Copy link

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit bb697e3 with source commit c219602.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 54 🔴 48 ↓ −5.9
Code coverage 🟢 91 🟢 91 ↓ −0.1
Security 🟡 81 🟡 81
Updates 🟡 80 🟡 80
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👎 2 groups regressed, 👍 1 audit improved, 👎 6 audits regressed, 10 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 54 🔴 48 ↓ −5.9
Code coverage Code coverage metrics 🟢 91 🟢 91 ↓ −0.1

15 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Initial server response time was short 🟩 Root document took 400 ms 🟥 Root document took 1,190 ms ↑ +194.3 %
Lighthouse Speed Index 🟨 4.9 s 🟥 7.8 s ↑ +57.8 %
Lighthouse Time to Interactive 🟥 11.3 s 🟥 14.8 s ↑ +31.4 %
Lighthouse Largest Contentful Paint 🟨 3.4 s 🟨 3.6 s ↑ +4.1 %
Lighthouse Total Blocking Time 🟥 2,700 ms 🟥 6,670 ms ↑ +147.2 %
Lighthouse First Contentful Paint 🟥 3.1 s 🟥 3.1 s ↓ −0.6 %
Code coverage Line coverage 🟩 90.9 % 🟩 90.8 % ↓ −0.1 %
Lighthouse Minimizes main-thread work 🟥 11.5 s 🟥 18.9 s ↑ +63.9 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,816 KiB 🟩 Total size was 1,820 KiB ↑ +0.2 %
Lighthouse JavaScript execution time 🟥 4.7 s 🟥 8.9 s ↑ +88 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +31.4 %
Lighthouse Max Potential First Input Delay 🟥 1,360 ms 🟥 2,760 ms ↑ +102.3 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 1,350 ms 🟥 Potential savings of 1,080 ms ↓ −20 %
Lighthouse Uses efficient cache policy on static assets 🟨 28 resources found 🟨 28 resources found ↑ +0.1 %
Lighthouse Server Backend Latencies 🟩 140 ms 🟩 70 ms ↓ −53.8 %
Lighthouse Network Round Trip Times 🟩 20 ms 🟩 40 ms ↑ +86.4 %
Lighthouse Avoids an excessive DOM size 🟥 2,141 elements 🟥 2,142 elements ↑ +0.1 %

571 other audits are unchanged.

Copy link
Collaborator

@matejchalk matejchalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vmasek vmasek merged commit 4777a83 into main Jan 6, 2025
14 of 17 checks passed
@vmasek vmasek deleted the tests-git-disable-gpg-sign branch January 6, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔬 testing writing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants