Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lint import extensions and fix missing .js extensions #894

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

matejchalk
Copy link
Collaborator

@matejchalk matejchalk commented Dec 17, 2024

Now that we build using tsc for ESM runtime, imports without .js extensions have to be linted to prevent runtime errors.

Copy link

Code PushUp

😟 Code PushUp report has regressed – compared target commit 6abe0e9 with source commit 284f755.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 54 🔴 41 ↓ −12.2
Code coverage 🟢 91 🟢 91
Security 🟡 81 🟡 81
Updates 🟡 80 🟡 80
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👎 1 group regressed, 👎 4 audits regressed, 11 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 54 🔴 41 ↓ −12.2

16 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Largest Contentful Paint 🟨 3.1 s 🟥 4.1 s ↑ +35.2 %
Lighthouse First Contentful Paint 🟨 2.8 s 🟥 3.7 s ↑ +29.8 %
Lighthouse Speed Index 🟥 6.4 s 🟥 8.5 s ↑ +32.5 %
Lighthouse Time to Interactive 🟥 16.6 s 🟥 17.6 s ↑ +6.1 %
Lighthouse Minimizes main-thread work 🟥 23.0 s 🟥 25.9 s ↑ +12.2 %
Lighthouse JavaScript execution time 🟥 9.0 s 🟥 10.9 s ↑ +21.9 %
Lighthouse Total Blocking Time 🟥 10,290 ms 🟥 11,570 ms ↑ +12.4 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +6.1 %
Lighthouse Max Potential First Input Delay 🟥 3,410 ms 🟥 3,770 ms ↑ +10.6 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,818 KiB 🟩 Total size was 1,819 KiB ↑ +0.1 %
Lighthouse Initial server response time was short 🟩 Root document took 400 ms 🟩 Root document took 580 ms ↑ +42.7 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 1,020 ms 🟥 Potential savings of 1,170 ms ↑ +14.6 %
Lighthouse Server Backend Latencies 🟩 160 ms 🟩 120 ms ↓ −24.4 %
Lighthouse Uses efficient cache policy on static assets 🟨 28 resources found 🟨 28 resources found ↑ +0.1 %
Lighthouse Network Round Trip Times 🟩 20 ms 🟩 20 ms ↓ −5.9 %

570 other audits are unchanged.

@matejchalk matejchalk merged commit 9d6eacf into main Dec 17, 2024
18 checks passed
@matejchalk matejchalk deleted the lint-extensions branch December 17, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants