Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-eslint): support new config format in nx helpers #885

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

matejchalk
Copy link
Collaborator

@matejchalk matejchalk commented Nov 29, 2024

Unblocks using flat config for projects using Nx helpers like eslintConfigFromAllNxProjects().

Related to:

Copy link

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 4357918 with source commit 13579f3.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 54 🔴 50 ↓ −4.3
Code coverage 🟢 90 🟢 90 ↑ +0.1
Custom checks 🟢 100 🟢 100
Security 🟡 78 🟡 78
Updates 🟡 76 🟡 76
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👍 1 group improved, 👎 1 group regressed, 👍 4 audits improved, 👎 4 audits regressed, 10 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 54 🔴 50 ↓ −4.3
Code coverage Code coverage metrics 🟢 90 🟢 90 ↑ +0.1

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Initial server response time was short 🟩 Root document took 450 ms 🟥 Root document took 1,200 ms ↑ +167.3 %
Lighthouse Speed Index 🟥 6.1 s 🟥 8.0 s ↑ +29.7 %
Lighthouse Largest Contentful Paint 🟨 3.0 s 🟨 3.3 s ↑ +12.1 %
Lighthouse First Contentful Paint 🟨 3.0 s 🟨 2.8 s ↓ −5.7 %
Lighthouse Time to Interactive 🟥 16.7 s 🟥 18.3 s ↑ +9.7 %
Code coverage Branch coverage 🟨 85.1 % 🟨 85.2 % ↑ +0.1 %
Code coverage Line coverage 🟩 90.5 % 🟩 90.6 % ↑ +0.1 %
Code coverage Function coverage 🟩 92.9 % 🟩 92.9 % ↑ +0.1 %
Lighthouse JavaScript execution time 🟥 9.3 s 🟥 12.4 s ↑ +32.7 %
Lighthouse Minimizes main-thread work 🟥 18.9 s 🟥 21.7 s ↑ +14.6 %
Lighthouse Total Blocking Time 🟥 6,790 ms 🟥 9,120 ms ↑ +34.3 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +9.7 %
Lighthouse Max Potential First Input Delay 🟥 2,930 ms 🟥 3,940 ms ↑ +34.7 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 1,510 ms 🟥 Potential savings of 1,020 ms ↓ −32 %
Lighthouse Uses efficient cache policy on static assets 🟨 29 resources found 🟨 29 resources found ↑ +0.1 %
Lighthouse Server Backend Latencies 🟩 100 ms 🟩 160 ms ↑ +67 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,827 KiB 🟩 Total size was 1,827 KiB ↑ +0.1 %
Lighthouse Network Round Trip Times 🟩 20 ms 🟩 30 ms ↑ +47.8 %

495 other audits are unchanged.

@matejchalk matejchalk marked this pull request as ready for review November 29, 2024 11:05
@matejchalk matejchalk merged commit effd5d2 into main Nov 29, 2024
19 checks passed
@matejchalk matejchalk deleted the fix-nx-eslint-helpers branch November 29, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants