Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update plugin-js-packages example #884

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Conversation

getlarge
Copy link
Collaborator

plugin and slug were inverted.

Check this poetic discussion for a reference.

`plugin` and `slug` were inverted.
@getlarge getlarge requested a review from matejchalk as a code owner November 28, 2024 17:09
@github-actions github-actions bot added the 📖 Project documentation improvements or additions to the project documentation label Nov 28, 2024
Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 🎉

Copy link

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit db32ee3 with source commit f0265fd.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 51 🟡 52 ↑ +1.3
Custom checks 🟢 100 🟢 100
Code coverage 🟢 90 🟢 90
Security 🟡 78 🟡 78
Updates 🟡 76 🟡 76
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👍 1 group improved, 👍 2 audits improved, 👎 2 audits regressed, 13 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 51 🟡 52 ↑ +1.3

19 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse First Contentful Paint 🟥 3.3 s 🟥 3.1 s ↓ −7.5 %
Lighthouse Time to Interactive 🟥 14.9 s 🟥 17.5 s ↑ +17.6 %
Lighthouse Largest Contentful Paint 🟨 3.3 s 🟨 3.2 s ↓ −2.8 %
Lighthouse Speed Index 🟥 5.9 s 🟥 6.0 s ↑ +1.7 %
Lighthouse Minimizes main-thread work 🟥 16.9 s 🟥 22.6 s ↑ +33.7 %
Lighthouse Total Blocking Time 🟥 4,870 ms 🟥 9,700 ms ↑ +99 %
Lighthouse JavaScript execution time 🟥 9.1 s 🟥 11.7 s ↑ +28.9 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +17.6 %
Lighthouse Max Potential First Input Delay 🟥 1,950 ms 🟥 2,600 ms ↑ +33.9 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 1,950 ms 🟥 Potential savings of 1,450 ms ↓ −25.8 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,822 KiB 🟩 Total size was 1,821 KiB ↓ −0.1 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 80 KiB 🟥 Potential savings of 80 KiB ↓ −34 %
Lighthouse Uses efficient cache policy on static assets 🟨 28 resources found 🟨 28 resources found ↓ −0.1 %
Lighthouse Server Backend Latencies 🟩 270 ms 🟩 170 ms ↓ −36.3 %
Lighthouse Initial server response time was short 🟩 Root document took 400 ms 🟩 Root document took 430 ms ↑ +7.4 %
Lighthouse Network Round Trip Times 🟩 30 ms 🟩 20 ms ↓ −35 %
Lighthouse Avoids an excessive DOM size 🟥 2,195 elements 🟥 2,194 elements ↓ −0.1 %

496 other audits are unchanged.

@matejchalk matejchalk merged commit 13579f3 into main Nov 28, 2024
17 checks passed
@matejchalk matejchalk deleted the update-js-packages-plugin branch November 28, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 Project documentation improvements or additions to the project documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants