Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: split eslint e2e #871

Merged
merged 44 commits into from
Nov 19, 2024
Merged

test: split eslint e2e #871

merged 44 commits into from
Nov 19, 2024

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Nov 9, 2024

Preconditions:

This PR moves all plugin-eslint related e2e tests into a separate project and uses a new project eslint-e2e-env to maintain the static files

@github-actions github-actions bot added 🔬 testing writing tests 🦾 CI/CD continuous integration and deployment 🛠️ tooling labels Nov 9, 2024
Copy link

github-actions bot commented Nov 9, 2024

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit a8e5543 with source commit 3fecae9.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 51 🔴 36 ↓ −15.2
Custom checks 🟡 67 🟡 67
Code coverage 🟡 90 🟡 90
Security 🟡 73 🟡 73
Updates 🟡 76 🟡 76
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👎 1 group regressed, 👍 1 audit improved, 👎 4 audits regressed, 12 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 51 🔴 36 ↓ −15.2

19 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Reduce unused CSS 🟥 Potential savings of 82 KiB 🟨 Potential savings of 82 KiB ↓ −100 %
Lighthouse Largest Contentful Paint 🟨 3.4 s 🟥 5.0 s ↑ +47.5 %
Lighthouse First Contentful Paint 🟨 2.8 s 🟥 4.1 s ↑ +43.7 %
Lighthouse Speed Index 🟥 6.5 s 🟥 8.3 s ↑ +26.9 %
Lighthouse Time to Interactive 🟥 16.1 s 🟥 17.0 s ↑ +5.3 %
Lighthouse Minimizes main-thread work 🟥 17.3 s 🟥 22.8 s ↑ +31.7 %
Lighthouse Total Blocking Time 🟥 5,690 ms 🟥 10,970 ms ↑ +92.8 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,821 KiB 🟩 Total size was 1,825 KiB ↑ +0.2 %
Lighthouse JavaScript execution time 🟥 10.3 s 🟥 12.5 s ↑ +22.1 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 1,030 ms 🟥 Potential savings of 60 ms ↓ −94.3 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +5.3 %
Lighthouse Uses efficient cache policy on static assets 🟨 28 resources found 🟨 28 resources found ↑ +0.1 %
Lighthouse Max Potential First Input Delay 🟥 2,810 ms 🟥 3,160 ms ↑ +12.5 %
Lighthouse Network Round Trip Times 🟩 30 ms 🟩 140 ms ↑ +335 %
Lighthouse Server Backend Latencies 🟩 230 ms 🟩 150 ms ↓ −36.1 %
Lighthouse Initial server response time was short 🟩 Root document took 380 ms 🟩 Root document took 410 ms ↑ +8 %
Lighthouse Avoids an excessive DOM size 🟥 2,250 elements 🟥 2,249 elements ↓ −0.1 %

496 other audits are unchanged.

@github-actions github-actions bot removed the 🦾 CI/CD continuous integration and deployment label Nov 9, 2024
@BioPhoton BioPhoton marked this pull request as ready for review November 9, 2024 16:33
@BioPhoton BioPhoton requested a review from matejchalk as a code owner November 9, 2024 16:33
e2e/cli-e2e/tests/collect.e2e.test.ts Show resolved Hide resolved
static-environments/eslint-e2e-env/project.json Outdated Show resolved Hide resolved
static-environments/eslint-e2e-env/project.json Outdated Show resolved Hide resolved
matejchalk
matejchalk previously approved these changes Nov 14, 2024
BioPhoton and others added 11 commits November 18, 2024 18:36
# Conflicts:
#	e2e/cli-e2e/tests/__snapshots__/collect.e2e.test.ts.snap
#	e2e/cli-e2e/tests/collect.e2e.test.ts
#	nx.json
# Conflicts:
#	e2e/cli-e2e/tests/__snapshots__/collect.e2e.test.ts.snap
#	e2e/cli-e2e/tests/collect.e2e.test.ts
#	e2e/plugin-coverage-e2e/mocks/fixtures/basic-setup/package.json
#	e2e/plugin-coverage-e2e/tests/collect.e2e.test.ts
#	nx.json
@BioPhoton BioPhoton requested a review from matejchalk November 19, 2024 14:27
@BioPhoton BioPhoton merged commit 1353b20 into main Nov 19, 2024
16 checks passed
@BioPhoton BioPhoton deleted the split-eslint-e2e branch November 19, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants