Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): pass project name to downloadReportArtifact and ignore errors #869

Merged
merged 4 commits into from
Nov 8, 2024

Conversation

matejchalk
Copy link
Collaborator

Artifact cache wasn't working correctly in monorepo mode. This change will allow provider integrations to download the correct report based on the project name. Also improved error handling and docs.

@matejchalk matejchalk added 🐛 bug something isn't working 📖 Project documentation improvements or additions to the project documentation 🧩 ci labels Nov 8, 2024
@matejchalk matejchalk self-assigned this Nov 8, 2024
@github-actions github-actions bot added the 🔬 testing writing tests label Nov 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 4341ea0 with source commit 61d49ea.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 54 🔴 49 ↓ −4.3
Code coverage 🟡 90 🟡 90 ↓ −0.1
Custom checks 🟡 67 🟡 67
Security 🟡 88 🟡 88
Updates 🟡 76 🟡 76
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👎 2 groups regressed, 👍 2 audits improved, 👎 4 audits regressed, 13 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 54 🔴 49 ↓ −4.3
Code coverage Code coverage metrics 🟡 90 🟡 90 ↓ −0.1

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Largest Contentful Paint 🟨 3.0 s 🟨 3.5 s ↑ +18.9 %
Lighthouse Speed Index 🟥 6.6 s 🟥 6.9 s ↑ +4.3 %
Lighthouse First Contentful Paint 🟨 3.0 s 🟨 2.9 s ↓ −1 %
Lighthouse Time to Interactive 🟥 17.7 s 🟥 16.9 s ↓ −4.5 %
Code coverage Branch coverage 🟨 84.8 % 🟨 84.7 % ↓ −0.1 %
Code coverage Line coverage 🟩 90.4 % 🟩 90.4 % ↓ −0.1 %
Lighthouse Total Blocking Time 🟥 6,850 ms 🟥 10,750 ms ↑ +56.9 %
Lighthouse Minimizes main-thread work 🟥 18.7 s 🟥 22.2 s ↑ +18.9 %
Lighthouse JavaScript execution time 🟥 11.0 s 🟥 11.9 s ↑ +8.5 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −4.5 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 1,140 ms 🟥 Potential savings of 480 ms ↓ −58 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 72 KiB 🟥 Potential savings of 72 KiB ↓ −100 %
Lighthouse Max Potential First Input Delay 🟥 2,850 ms 🟥 3,130 ms ↑ +10.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,818 KiB 🟩 Total size was 1,817 KiB ↓ −0.1 %
Lighthouse Initial server response time was short 🟩 Root document took 590 ms 🟩 Root document took 430 ms ↓ −26.6 %
Lighthouse Server Backend Latencies 🟩 230 ms 🟩 100 ms ↓ −56.2 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↑ +0.1 %
Lighthouse Network Round Trip Times 🟩 70 ms 🟩 60 ms ↓ −21.3 %
Lighthouse Avoids an excessive DOM size 🟥 2,245 elements 🟥 2,244 elements ↓ −0.1 %

494 other audits are unchanged.

@matejchalk matejchalk merged commit 3df4a71 into main Nov 8, 2024
17 checks passed
@matejchalk matejchalk deleted the ci-artifact-fix branch November 8, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug something isn't working 🧩 ci 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants