-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: standardize undefined handling for categories #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared target commit cc98195 with source commit 61d49ea. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 1 group improved, 👎 1 group regressed, 👍 5 audits improved, 👎 1 audit regressed, 14 audits changed without impacting score🗃️ Groups
18 other groups are unchanged. 🛡️ Audits
493 other audits are unchanged. |
vmasek
reviewed
Nov 7, 2024
vmasek
previously approved these changes
Nov 7, 2024
hanna-skryl
commented
Nov 7, 2024
matejchalk
reviewed
Nov 8, 2024
matejchalk
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #518
This refactor standardizes the handling of categories as undefined throughout the CLI pipeline until conversion to the GQL report. Previously, an empty array was assigned by default in middlewares, leading to inconsistencies with
CoreConfig
wherecategories
are optional.By removing the default empty array,
categories
remain undefined unless explicitly provided. This update improves type consistency, ensuring that categories are only included in the final report if defined. When no categories are provided, the JSON report omits the categories field, and the Markdown report summary table indicates that there are 0 categories.