Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(models): allow non-integers in audit values diff #867

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

matejchalk
Copy link
Collaborator

@matejchalk matejchalk added the 🐛 bug something isn't working label Nov 7, 2024
@matejchalk matejchalk self-assigned this Nov 7, 2024
Copy link

github-actions bot commented Nov 7, 2024

Code PushUp

😟 Code PushUp report has regressed – compared target commit 46bd9d0 with source commit 52afea5.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 52 🟡 51 ↓ −1.1
Custom checks 🟡 67 🟡 67
Code coverage 🟡 90 🟡 90
Security 🟡 88 🟡 88
Updates 🟡 76 🟡 76
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👎 1 group regressed, 👎 4 audits regressed, 14 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 52 🟡 51 ↓ −1.1

19 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Time to Interactive 🟥 14.9 s 🟥 18.5 s ↑ +23.8 %
Lighthouse Speed Index 🟨 5.5 s 🟨 5.8 s ↑ +4.1 %
Lighthouse First Contentful Paint 🟥 3.2 s 🟥 3.3 s ↑ +2 %
Lighthouse Largest Contentful Paint 🟨 3.3 s 🟨 3.4 s ↑ +1.9 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,814 KiB 🟩 Total size was 1,810 KiB ↓ −0.2 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +23.8 %
Lighthouse JavaScript execution time 🟥 9.8 s 🟥 12.4 s ↑ +26.3 %
Lighthouse Total Blocking Time 🟥 6,660 ms 🟥 8,790 ms ↑ +32 %
Lighthouse Max Potential First Input Delay 🟥 2,570 ms 🟥 4,330 ms ↑ +68.9 %
Lighthouse Minimizes main-thread work 🟥 20.0 s 🟥 21.5 s ↑ +7.7 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↑ +0.1 %
Lighthouse Initial server response time was short 🟩 Root document took 410 ms 🟩 Root document took 510 ms ↑ +23.8 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 1,770 ms 🟥 Potential savings of 1,680 ms ↓ −5.4 %
Lighthouse Server Backend Latencies 🟩 140 ms 🟩 120 ms ↓ −14.7 %
Lighthouse Avoid non-composited animations 🟩 0 🟩 5 animated elements found ↑ +∞ %
Lighthouse Avoids an excessive DOM size 🟥 2,247 elements 🟥 2,248 elements ↑ +0.1 %
Lighthouse Network Round Trip Times 🟩 20 ms 🟩 20 ms ↑ +1.5 %
Code coverage Line coverage 🟩 90.4 % 🟩 90.4 % ↓ −0.1 %

495 other audits are unchanged.

@matejchalk matejchalk merged commit 61d49ea into main Nov 7, 2024
17 checks passed
@matejchalk matejchalk deleted the fix-audit-values-diff-schema branch November 7, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug something isn't working 🧩 models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants