Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-eslint,plugin-coverage): future-proof version range of nx peer deps #866

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

matejchalk
Copy link
Collaborator

@matejchalk matejchalk commented Nov 7, 2024

Not possible to install these plugins without --legacy-peer-deps otherwise for Nx 20.

Copy link

github-actions bot commented Nov 7, 2024

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit f0f7c5b with source commit d61a19d.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 53 🟡 52 ↓ −0.6
Custom checks 🟡 67 🟡 67
Code coverage 🟡 90 🟡 90
Security 🟡 88 🟡 88
Updates 🟡 76 🟡 76
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👎 1 group regressed, 👍 2 audits improved, 👎 1 audit regressed, 14 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 53 🟡 52 ↓ −0.6

19 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Speed Index 🟥 7.2 s 🟥 6.2 s ↓ −14.4 %
Lighthouse Largest Contentful Paint 🟨 3.1 s 🟨 3.3 s ↑ +9.6 %
Lighthouse Time to Interactive 🟥 17.9 s 🟥 16.6 s ↓ −7.3 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,816 KiB 🟩 Total size was 1,824 KiB ↑ +0.4 %
Lighthouse Minimizes main-thread work 🟥 24.4 s 🟥 18.6 s ↓ −23.9 %
Lighthouse Total Blocking Time 🟥 10,140 ms 🟥 6,410 ms ↓ −36.8 %
Lighthouse JavaScript execution time 🟥 11.8 s 🟥 9.3 s ↓ −21.4 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −7.3 %
Lighthouse Max Potential First Input Delay 🟥 3,720 ms 🟥 3,090 ms ↓ −16.9 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 1,120 ms 🟥 Potential savings of 780 ms ↓ −30.1 %
Lighthouse Initial server response time was short 🟩 Root document took 550 ms 🟩 Root document took 500 ms ↓ −9.5 %
Lighthouse Server Backend Latencies 🟩 190 ms 🟩 160 ms ↓ −14.2 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 72 KiB 🟥 Potential savings of 72 KiB ↓ −3.2 %
Lighthouse Network Round Trip Times 🟩 40 ms 🟩 40 ms ↑ +19.6 %
Lighthouse First Contentful Paint 🟨 2.8 s 🟨 2.8 s ↓ −0.2 %
Lighthouse Uses efficient cache policy on static assets 🟨 29 resources found 🟨 29 resources found ↑ +0.1 %
Lighthouse Avoid non-composited animations 🟩 0 🟩 25 animated elements found ↑ +∞ %

496 other audits are unchanged.

@matejchalk matejchalk merged commit 52afea5 into main Nov 7, 2024
18 checks passed
@matejchalk matejchalk deleted the fix-peer-deps branch November 7, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants