Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-eslint): add exclude option for Nx projects #863

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

hanna-skryl
Copy link
Collaborator

Closes #496

This PR adds an exclude option to the eslintConfigFromAllNxProjects function, allowing Nx projects to be selectively excluded from ESLint configuration and additionally moves the toProjectGraph helper into test-utils for reuse across test suites.

@hanna-skryl hanna-skryl self-assigned this Oct 25, 2024
@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 eslint-plugin labels Oct 25, 2024
Copy link

github-actions bot commented Oct 25, 2024

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 13f3787 with source commit d8a7eb2.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 56 🟡 55 ↓ −1.2
Code coverage 🟡 90 🟡 90 ↓ −0.1
Custom checks 🟡 67 🟡 67
Security 🟡 83 🟡 83
Updates 🟡 76 🟡 76
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👎 2 groups regressed, 👍 4 audits improved, 👎 2 audits regressed, 16 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 56 🟡 55 ↓ −1.2
Code coverage Code coverage metrics 🟡 90 🟡 90 ↓ −0.1

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Largest Contentful Paint 🟨 2.8 s 🟨 3.1 s ↑ +7.8 %
Lighthouse First Contentful Paint 🟨 2.8 s 🟨 2.8 s ↓ −3.2 %
Lighthouse First Meaningful Paint 🟨 2.8 s 🟨 2.8 s ↓ −3.2 %
Lighthouse Time to Interactive 🟥 16.5 s 🟥 15.7 s ↓ −4.9 %
Code coverage Line coverage 🟩 90.7 % 🟩 90.4 % ↓ −0.3 %
Code coverage Function coverage 🟩 92.4 % 🟩 92.4 % ↑ +0.1 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↑ +0.6 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,813 KiB 🟩 Total size was 1,815 KiB ↑ +0.1 %
Lighthouse Max Potential First Input Delay 🟥 3,190 ms 🟥 1,710 ms ↓ −46.3 %
Lighthouse Minimizes main-thread work 🟥 16.9 s 🟥 18.2 s ↑ +8 %
Lighthouse Total Blocking Time 🟥 5,680 ms 🟥 6,790 ms ↑ +19.6 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −4.9 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 570 ms 🟥 Potential savings of 1,190 ms ↑ +108.8 %
Lighthouse JavaScript execution time 🟥 9.9 s 🟥 9.5 s ↓ −3.8 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 56 KiB 🟥 Potential savings of 70 KiB ↑ +93.8 %
Lighthouse Server Backend Latencies 🟩 240 ms 🟩 100 ms ↓ −56.3 %
Lighthouse Initial server response time was short 🟩 Root document took 410 ms 🟩 Root document took 350 ms ↓ −14 %
Lighthouse Network Round Trip Times 🟩 60 ms 🟩 30 ms ↓ −49.4 %
Lighthouse Speed Index 🟥 5.9 s 🟥 5.9 s ↓ −0.5 %
JS Packages Outdated NPM dev dependencies. 🟨 45 outdated package versions (26 major, 14 minor, 1 preminor, 4 patch) 🟨 46 outdated package versions (26 major, 15 minor, 1 preminor, 4 patch) ↑ +2.2 %
Lighthouse Avoids an excessive DOM size 🟥 2,232 elements 🟥 2,231 elements ↓ −0.1 %
Code coverage Branch coverage 🟨 84.8 % 🟨 84.8 % ↑ +0.1 %

491 other audits are unchanged.

@hanna-skryl hanna-skryl force-pushed the feat/configure-nx-project-finder branch from 16a8a98 to 0a280e6 Compare October 25, 2024 20:45
@hanna-skryl hanna-skryl marked this pull request as ready for review October 25, 2024 21:06
@hanna-skryl hanna-skryl requested a review from vmasek October 28, 2024 12:49
@hanna-skryl hanna-skryl merged commit e9560f5 into main Oct 29, 2024
13 of 16 checks passed
@hanna-skryl hanna-skryl deleted the feat/configure-nx-project-finder branch October 29, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧩 eslint-plugin 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make eslintConfigFromNxProjects more flexible
2 participants