Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): always log single perfect audit #861

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

hanna-skryl
Copy link
Collaborator

Fixes #854

@hanna-skryl hanna-skryl self-assigned this Oct 22, 2024
Copy link

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit e080924 with source commit 924a8bf.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 54 🟡 51 ↓ −3.5
Code coverage 🟡 90 🟡 90 ↑ +0.1
Custom checks 🟡 67 🟡 67
Security 🟡 83 🟡 83
Updates 🟡 76 🟡 76
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👍 1 group improved, 👎 1 group regressed, 👍 1 audit improved, 👎 4 audits regressed, 13 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 54 🟡 51 ↓ −3.5
Code coverage Code coverage metrics 🟡 90 🟡 90 ↑ +0.1

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Largest Contentful Paint 🟨 3.0 s 🟨 3.5 s ↑ +14.4 %
Lighthouse First Contentful Paint 🟨 2.9 s 🟨 3.0 s ↑ +2.1 %
Lighthouse First Meaningful Paint 🟨 2.9 s 🟨 3.0 s ↑ +2.1 %
Lighthouse Speed Index 🟥 5.9 s 🟥 5.9 s ↑ +0.7 %
Code coverage Branch coverage 🟨 84.8 % 🟨 84.8 % ↑ +0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,803 KiB 🟩 Total size was 1,807 KiB ↑ +0.2 %
Lighthouse Minimizes main-thread work 🟥 16.3 s 🟥 17.0 s ↑ +3.8 %
Lighthouse Total Blocking Time 🟥 5,150 ms 🟥 4,730 ms ↓ −8 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 680 ms 🟥 Potential savings of 990 ms ↑ +46.2 %
Lighthouse Max Potential First Input Delay 🟥 2,400 ms 🟥 2,620 ms ↑ +9.1 %
Lighthouse Time to Interactive 🟥 15.5 s 🟥 15.4 s ↓ −1 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −1 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↓ −0.1 %
Lighthouse JavaScript execution time 🟥 8.3 s 🟥 8.2 s ↓ −0.6 %
Lighthouse Server Backend Latencies 🟩 240 ms 🟩 180 ms ↓ −21.5 %
Lighthouse Network Round Trip Times 🟩 50 ms 🟩 10 ms ↓ −79.6 %
Lighthouse Initial server response time was short 🟩 Root document took 370 ms 🟩 Root document took 350 ms ↓ −5.3 %
Code coverage Line coverage 🟩 90.7 % 🟩 90.7 % ↑ +0.1 %

495 other audits are unchanged.

@hanna-skryl hanna-skryl marked this pull request as ready for review October 23, 2024 00:04
@hanna-skryl hanna-skryl requested a review from vmasek October 23, 2024 00:05
@hanna-skryl hanna-skryl merged commit d8a7eb2 into main Oct 23, 2024
14 of 17 checks passed
@hanna-skryl hanna-skryl deleted the fix/log-single-perfect-audit branch October 23, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't truncate 1 perfect audit in stdout
2 participants