Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update and fix knip #860

Merged
merged 1 commit into from
Oct 19, 2024
Merged

refactor: update and fix knip #860

merged 1 commit into from
Oct 19, 2024

Conversation

vmasek
Copy link
Collaborator

@vmasek vmasek commented Oct 18, 2024

image

Signed-off-by: Vojtech Masek <[email protected]>
Copy link

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 265a883 with source commit 3465e16.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 55 🔴 41 ↓ −13.8
Security 🟡 82 🟡 83 ↑ +0.8
Updates 🟡 76 🟡 76 ↓ −0.7
Code coverage 🟡 90 🟡 90 ↑ +0.1
Custom checks 🟡 67 🟡 67
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👍 2 groups improved, 👎 2 groups regressed, 👍 7 audits improved, 👎 5 audits regressed, 11 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 55 🔴 41 ↓ −13.8
JS Packages NPM audit 🟡 82 🟡 83 ↑ +0.8
JS Packages NPM outdated dependencies 🟡 76 🟡 76 ↓ −0.7
Code coverage Code coverage metrics 🟡 90 🟡 90 ↑ +0.1

16 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 630 ms 🟨 Potential savings of 0 ms ↓ −100 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 70 KiB 🟨 Potential savings of 70 KiB ↓ −100 %
Lighthouse Largest Contentful Paint 🟨 3.0 s 🟥 4.2 s ↑ +41.5 %
Lighthouse First Contentful Paint 🟨 2.7 s 🟥 3.5 s ↑ +33.9 %
Lighthouse First Meaningful Paint 🟨 2.7 s 🟨 3.6 s ↑ +36.5 %
Lighthouse Speed Index 🟥 6.4 s 🟥 8.4 s ↑ +30.2 %
JS Packages Vulnerabilities for NPM dev dependencies. 🟥 12 vulnerabilities (4 high, 8 moderate) 🟥 11 vulnerabilities (4 high, 7 moderate) ↓ −8.3 %
Lighthouse Time to Interactive 🟥 17.2 s 🟥 16.7 s ↓ −3.3 %
JS Packages Outdated NPM prod dependencies. 🟨 15 outdated package versions (5 major, 5 minor, 5 patch) 🟨 14 outdated package versions (5 major, 5 minor, 4 patch) ↓ −6.7 %
JS Packages Outdated NPM dev dependencies. 🟨 49 outdated package versions (27 major, 16 minor, 1 preminor, 4 patch, 1 prerelease) 🟨 45 outdated package versions (26 major, 14 minor, 1 preminor, 4 patch) ↓ −8.2 %
Code coverage Function coverage 🟩 92.2 % 🟩 92.4 % ↑ +0.2 %
Code coverage Line coverage 🟩 90.7 % 🟩 90.7 % ↑ +0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,807 KiB 🟩 Total size was 1,804 KiB ↓ −0.2 %
Lighthouse Minimizes main-thread work 🟥 20.8 s 🟥 23.9 s ↑ +14.6 %
Lighthouse JavaScript execution time 🟥 10.6 s 🟥 12.2 s ↑ +14.4 %
Lighthouse Total Blocking Time 🟥 7,930 ms 🟥 8,910 ms ↑ +12.3 %
Lighthouse Max Potential First Input Delay 🟥 3,060 ms 🟥 2,140 ms ↓ −30.1 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −3.3 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↑ +0.1 %
Lighthouse Server Backend Latencies 🟩 220 ms 🟩 120 ms ↓ −47.3 %
Lighthouse Network Round Trip Times 🟩 10 ms 🟩 50 ms ↑ +213.2 %
Lighthouse Initial server response time was short 🟥 Root document took 900 ms 🟥 Root document took 880 ms ↓ −2.5 %
Lighthouse Avoids an excessive DOM size 🟥 2,235 elements 🟥 2,234 elements ↓ −0.1 %

490 other audits are unchanged.

@vmasek vmasek merged commit 924a8bf into main Oct 19, 2024
14 of 18 checks passed
@vmasek vmasek deleted the update-and-fix-knip branch October 19, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants