Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): handle monorepo mode in non-PR flow #859

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

matejchalk
Copy link
Collaborator

Came across error in monorepo mode when triggered on push and not pull_request. Falls through to standalone mode.

image

@matejchalk matejchalk self-assigned this Oct 18, 2024
@matejchalk matejchalk added 🐛 bug something isn't working 🧩 ci labels Oct 18, 2024
@matejchalk matejchalk requested a review from vmasek October 18, 2024 08:49
Copy link

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 0a72be3 with source commit 6244f3f.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 49 🔴 45 ↓ −3.7
Code coverage 🟡 90 🟡 90 ↓ −0.1
Custom checks 🟡 67 🟡 67
Security 🟡 82 🟡 82
Updates 🟡 75 🟡 75
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👎 2 groups regressed, 👍 3 audits improved, 👎 2 audits regressed, 15 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 49 🔴 45 ↓ −3.7
Code coverage Code coverage metrics 🟡 90 🟡 90 ↓ −0.1

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Largest Contentful Paint 🟨 3.3 s 🟨 4.0 s ↑ +19.9 %
Lighthouse Speed Index 🟥 7.6 s 🟥 6.8 s ↓ −9.8 %
Lighthouse First Meaningful Paint 🟨 3.3 s 🟨 3.2 s ↓ −3.6 %
Lighthouse First Contentful Paint 🟥 3.2 s 🟥 3.1 s ↓ −3.6 %
Code coverage Line coverage 🟩 90.7 % 🟩 90.7 % ↓ −0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,814 KiB 🟩 Total size was 1,810 KiB ↓ −0.2 %
Lighthouse JavaScript execution time 🟥 11.2 s 🟥 12.1 s ↑ +8 %
Lighthouse Minimizes main-thread work 🟥 23.6 s 🟥 24.5 s ↑ +3.8 %
Lighthouse Total Blocking Time 🟥 9,270 ms 🟥 10,070 ms ↑ +8.6 %
Lighthouse Time to Interactive 🟥 18.2 s 🟥 18.8 s ↑ +3.4 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +3.4 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 870 ms 🟥 Potential savings of 1,170 ms ↑ +34.9 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↑ +0.1 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 70 KiB 🟥 Potential savings of 70 KiB ↑ +93.8 %
Lighthouse Max Potential First Input Delay 🟥 3,380 ms 🟥 3,530 ms ↑ +4.4 %
Lighthouse Initial server response time was short 🟩 Root document took 460 ms 🟩 Root document took 390 ms ↓ −14.2 %
Lighthouse Server Backend Latencies 🟩 140 ms 🟩 200 ms ↑ +45.9 %
Lighthouse Network Round Trip Times 🟩 90 ms 🟩 60 ms ↓ −35.5 %
Lighthouse Avoid large layout shifts 🟩 1 layout shift found 🟩 0 ↓ −100 %
Lighthouse Cumulative Layout Shift 🟩 0 🟩 0 ↓ −100 %

493 other audits are unchanged.

@matejchalk matejchalk merged commit d7ba5a3 into main Oct 18, 2024
14 of 17 checks passed
@matejchalk matejchalk deleted the fix-ci-monorepo-no-pr branch October 18, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug something isn't working 🧩 ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants