Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(utils): remove multiple globs libs from perf benchmark example #856

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

vmasek
Copy link
Collaborator

@vmasek vmasek commented Oct 18, 2024

closes #845
part of #776

Copy link

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 87b9fbc with source commit f01bcc4.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 46 🟡 53 ↑ +7.2
Updates 🟡 75 🟡 75 ↓ −0.2
Custom checks 🟡 67 🟡 67
Code coverage 🟡 90 🟡 90
Security 🟡 82 🟡 82
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👍 1 group improved, 👎 1 group regressed, 👍 5 audits improved, 👎 1 audit regressed, 12 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 46 🟡 53 ↑ +7.2
JS Packages NPM outdated dependencies 🟡 75 🟡 75 ↓ −0.2

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Largest Contentful Paint 🟨 3.9 s 🟨 3.2 s ↓ −19 %
Lighthouse First Contentful Paint 🟥 3.2 s 🟨 2.9 s ↓ −11.1 %
Lighthouse First Meaningful Paint 🟨 3.2 s 🟨 2.9 s ↓ −11.1 %
Lighthouse Speed Index 🟥 7.0 s 🟥 6.4 s ↓ −7.7 %
JS Packages Outdated NPM dev dependencies. 🟨 58 outdated package versions (33 major, 16 minor, 1 preminor, 7 patch, 1 prerelease) 🟨 57 outdated package versions (33 major, 16 minor, 1 preminor, 6 patch, 1 prerelease) ↓ −1.7 %
Lighthouse Time to Interactive 🟥 17.6 s 🟥 16.6 s ↓ −5.5 %
Lighthouse Minimizes main-thread work 🟥 21.7 s 🟥 18.8 s ↓ −13.6 %
Lighthouse Total Blocking Time 🟥 7,640 ms 🟥 6,420 ms ↓ −15.9 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,812 KiB 🟩 Total size was 1,811 KiB ↓ −0.1 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −5.5 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↑ +0.1 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 990 ms 🟥 Potential savings of 340 ms ↓ −65.5 %
Lighthouse JavaScript execution time 🟥 11.0 s 🟥 10.4 s ↓ −5.4 %
Lighthouse Initial server response time was short 🟩 Root document took 390 ms 🟩 Root document took 500 ms ↑ +26.1 %
Lighthouse Server Backend Latencies 🟩 90 ms 🟩 130 ms ↑ +45 %
Lighthouse Network Round Trip Times 🟩 50 ms 🟩 70 ms ↑ +21.5 %
Lighthouse Max Potential First Input Delay 🟥 3,530 ms 🟥 3,540 ms ↑ +0.2 %
Lighthouse Avoids an excessive DOM size 🟥 2,251 elements 🟥 2,249 elements ↓ −0.1 %

495 other audits are unchanged.

@vmasek vmasek merged commit 6244f3f into main Oct 18, 2024
14 of 17 checks passed
@vmasek vmasek deleted the perf-bechnmark-refactor branch October 18, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minimize benchmark dependencies in main branch
2 participants