Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use toSorted in appropriate places #855

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

vmasek
Copy link
Collaborator

@vmasek vmasek commented Oct 18, 2024

closes #425

Copy link

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit b89bed8 with source commit f01bcc4.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 46 🔴 45 ↓ −1.3
Custom checks 🟡 67 🟡 67
Code coverage 🟡 90 🟡 90
Security 🟡 82 🟡 82
Updates 🟡 75 🟡 75
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👎 1 group regressed, 👍 1 audit improved, 👎 4 audits regressed, 12 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 46 🔴 45 ↓ −1.3

19 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse First Contentful Paint 🟥 3.2 s 🟥 3.4 s ↑ +5.1 %
Lighthouse First Meaningful Paint 🟨 3.2 s 🟨 3.4 s ↑ +5.1 %
Lighthouse Largest Contentful Paint 🟨 3.9 s 🟨 4.0 s ↑ +2.2 %
Lighthouse Speed Index 🟥 7.0 s 🟥 7.0 s ↑ +0.6 %
Lighthouse Time to Interactive 🟥 17.6 s 🟥 16.3 s ↓ −7.5 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −7.5 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,812 KiB 🟩 Total size was 1,811 KiB ↓ −0.1 %
Lighthouse Max Potential First Input Delay 🟥 3,530 ms 🟥 4,360 ms ↑ +23.5 %
Lighthouse Total Blocking Time 🟥 7,640 ms 🟥 7,050 ms ↓ −7.7 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↑ +0.1 %
Lighthouse JavaScript execution time 🟥 11.0 s 🟥 10.8 s ↓ −1.4 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 990 ms 🟥 Potential savings of 1,100 ms ↑ +10.9 %
Lighthouse Initial server response time was short 🟩 Root document took 390 ms 🟩 Root document took 360 ms ↓ −8.1 %
Lighthouse Network Round Trip Times 🟩 50 ms 🟩 70 ms ↑ +32.2 %
Lighthouse Server Backend Latencies 🟩 90 ms 🟩 110 ms ↑ +19.4 %
Lighthouse Avoids an excessive DOM size 🟥 2,251 elements 🟥 2,249 elements ↓ −0.1 %
Lighthouse Minimizes main-thread work 🟥 21.7 s 🟥 21.7 s ↓ −0.1 %

496 other audits are unchanged.

@vmasek vmasek merged commit 46d385e into main Oct 18, 2024
14 of 17 checks passed
@vmasek vmasek deleted the to-sorted-refactor branch October 18, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use EcmaScript 2023 for toSorted
2 participants