Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: tiny lint fixes #851

Merged
merged 1 commit into from
Oct 17, 2024
Merged

refactor: tiny lint fixes #851

merged 1 commit into from
Oct 17, 2024

Conversation

vmasek
Copy link
Collaborator

@vmasek vmasek commented Oct 16, 2024

No description provided.

Signed-off-by: Vojtech Masek <[email protected]>
Copy link

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 3f90d53 with source commit 5f5a2e8.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 53 🟡 52 ↓ −1.5
Code style 🟢 99 🟢 100 ↑ +0.9
Custom checks 🟡 67 🟡 67
Code coverage 🟡 90 🟡 90
Security 🟡 82 🟡 82
Updates 🟡 75 🟡 75
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
👍 1 group improved, 👎 1 group regressed, 👍 3 audits improved, 👎 3 audits regressed, 14 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 53 🟡 52 ↓ −1.5
ESLint Suggestions 🟢 99 🟢 100 ↑ +0.9

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
ESLint Disallow magic numbers 🟥 4 warnings 🟩 passed ↓ −100 %
ESLint String literals should not be duplicated 🟥 1 warning 🟩 passed ↓ −100 %
Lighthouse Speed Index 🟨 5.2 s 🟨 5.8 s ↑ +12.1 %
Lighthouse First Contentful Paint 🟥 3.1 s 🟥 3.3 s ↑ +5.5 %
Lighthouse First Meaningful Paint 🟨 3.1 s 🟨 3.3 s ↑ +5.5 %
Lighthouse Time to Interactive 🟥 18.4 s 🟥 16.7 s ↓ −9 %
Lighthouse Total Blocking Time 🟥 8,810 ms 🟥 6,960 ms ↓ −21 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −9 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,819 KiB 🟩 Total size was 1,820 KiB ↑ +0.1 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↑ +0.2 %
Lighthouse JavaScript execution time 🟥 10.2 s 🟥 9.5 s ↓ −6.9 %
Lighthouse Minimizes main-thread work 🟥 19.9 s 🟥 19.5 s ↓ −2.2 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 1,140 ms 🟥 Potential savings of 1,490 ms ↑ +30.6 %
Lighthouse Initial server response time was short 🟩 Root document took 530 ms 🟩 Root document took 440 ms ↓ −18.1 %
Lighthouse Max Potential First Input Delay 🟥 4,130 ms 🟥 4,070 ms ↓ −1.5 %
Lighthouse Server Backend Latencies 🟩 180 ms 🟩 220 ms ↑ +23.2 %
Lighthouse Network Round Trip Times 🟩 70 ms 🟩 80 ms ↑ +15.2 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 70 KiB 🟥 Potential savings of 70 KiB ↑ +6.7 %
Lighthouse Largest Contentful Paint 🟨 3.3 s 🟨 3.3 s ↓ −0.1 %
Lighthouse Avoids an excessive DOM size 🟥 2,243 elements 🟥 2,244 elements ↑ +0.1 %

493 other audits are unchanged.

@vmasek vmasek merged commit ee55c03 into main Oct 17, 2024
14 of 17 checks passed
@vmasek vmasek deleted the tiny-lint-fixes branch October 17, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants