Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update Nx 19 & other dependencies #811

Merged
merged 45 commits into from
Dec 9, 2024
Merged

build: update Nx 19 & other dependencies #811

merged 45 commits into from
Dec 9, 2024

Conversation

vmasek
Copy link
Collaborator

@vmasek vmasek commented Sep 4, 2024 •
edited
Loading

closes #771
closes #776
closes #835

@vmasek vmasek added the 🌊 Nx Nx related issues label Sep 4, 2024
@vmasek vmasek self-assigned this Sep 4, 2024
@vmasek
Copy link
Collaborator Author

vmasek commented Sep 4, 2024

Investigation of failing CI in progress 👀

@vmasek vmasek force-pushed the nx-19-update branch 4 times, most recently from f30595f to 6e16658 Compare September 5, 2024 18:27
@vmasek vmasek force-pushed the nx-19-update branch 3 times, most recently from cd2ca75 to b3dd03d Compare September 6, 2024 18:02
@github-actions github-actions bot removed the 🧩 core label Sep 6, 2024
@vmasek vmasek force-pushed the nx-19-update branch 2 times, most recently from 9218855 to b994b9f Compare September 6, 2024 18:45
@github-actions github-actions bot removed 📖 Project documentation improvements or additions to the project documentation 🧩 utils labels Sep 6, 2024
vmasek added 14 commits December 8, 2024 16:10
@vmasek
refactor: ignore all config files in eslint
ab04f35
@vmasek
test(plugin-eslint): add tsconfig for todos-app
814cf46 
@code-pushup/cli-source:code-pushup task (run in CI) fails without it
@vmasek
refactor: code pushup core config type import
588ec76
@vmasek
refactor: reformat yargs file
676e1fa
@vmasek
build: remove unnecessary types property from package json as it is g…
321d21f 
…enerated
@vmasek
build: remove unnecessary tslib dependency form sub packages as we do…
60cdd93 
… not use import helpers
@vmasek
refactor: code pushup merge configs helper direct import
8622189
@vmasek
refactor: code pushup preset direct imports
f6462e4
@vmasek
refactor: correct examples dist import
c9122be
@vmasek
test: correct double file extension imports
1e042e6
@vmasek
test: correct path for args testing
697470e
@vmasek
refactor(nx-plugin): target specific deprecation with ignore
ef62518
@vmasek
build: set import helpers usage to explicit false to mitigate tslib
08fa7b9
@vmasek
build(nx-plugin): keep supported nx version at >17 and <=19
4b70f42
@vmasek vmasek force-pushed the nx-19-update branch 3 times, most recently from d0422c3 to 537362d Compare December 8, 2024 16:22
@vmasek vmasek requested a review from matejchalk December 8, 2024 17:00
BioPhoton
BioPhoton reviewed Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need to touch all imports in the code base to migrate to nx v19?

I would really want to avoid this.

@vmasek
Copy link
Collaborator Author

vmasek commented Dec 9, 2024 •
edited
Loading

Do we really need to touch all imports in the code base to migrate to nx v19?

I would really want to avoid this.

I know it is quite big change but is seems like the best direction we could go.
We are dropping a bundler and going for pure TS compilation getting errors more streamlined (accurate) and consistent import behavior.

@vmasek vmasek merged commit 9099514 into main Dec 9, 2024
16 checks passed
@vmasek vmasek deleted the nx-19-update branch December 9, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejchalk matejchalk matejchalk approved these changes

@BioPhoton BioPhoton BioPhoton approved these changes

Assignees

@vmasek vmasek

Labels
🧩 ci 🧩 cli 🧩 core 🧩 coverage-plugin 🧩 create-cli 🧩 eslint-plugin 🧩 js-packages-plugin Plugin for audit and outdated dependencies 🧩 lighthouse-plugin 🧩 models 🌊 Nx Nx related issues 🧩 nx-plugin 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🛠️ tooling 🧩 utils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't bundle build output reduce dependencies ci: migrate to Nx 19
3 participants
@vmasek @BioPhoton @matejchalk