Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(nx-plugin-e2e): refactor to use new test helper #785

Merged
merged 16 commits into from
Aug 6, 2024

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Aug 6, 2024

Precondition of #773

Included changes:

  • use new test helper
  • fix package name
  • add skip flags to enable more tests
  • test skip flags

Copy link

github-actions bot commented Aug 6, 2024

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 068ffb9 with source commit 1041524.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 45 🟡 52 ↑ +6.8
Code coverage 🟡 90 🟡 90 ↑ +0
Custom checks 🟡 67 🟡 67
Security 🟢 100 🟢 100
Updates 🟡 78 🟡 78
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 99 🟢 99

🗃️ Groups

👍 2 groups improved
🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 45 🟡 52 ↑ +6.8
Code coverage Code coverage metrics 🟡 90 🟡 90 ↑ +0

18 other groups are unchanged.

🛡️ Audits

👍 5 audits improved, 👎 1 audit regressed, 14 audits changed without impacting score
🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse First Contentful Paint 🟥 3.2 s 🟨 2.5 s ↓ −22 %
Lighthouse First Meaningful Paint 🟨 3.4 s 🟨 2.5 s ↓ −25 %
Lighthouse Largest Contentful Paint 🟨 3.8 s 🟨 3.3 s ↓ −14 %
Lighthouse Speed Index 🟥 7.6 s 🟥 7.2 s ↓ −5 %
Code coverage Line coverage 🟩 91.6 % 🟩 91.6 % ↓ +0 %
Code coverage Branch coverage 🟨 84.3 % 🟨 84.3 % ↑ +0 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,798 KiB 🟩 Total size was 1,790 KiB ↓ +0 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 1,580 ms 🟥 Potential savings of 580 ms ↓ −63 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↑ +0 %
Lighthouse JavaScript execution time 🟥 10.4 s 🟥 10.9 s ↑ +5 %
Lighthouse Minimizes main-thread work 🟥 23.3 s 🟥 22.8 s ↓ −2 %
Lighthouse Total Blocking Time 🟥 8,990 ms 🟥 8,550 ms ↓ −5 %
Lighthouse Max Potential First Input Delay 🟥 3,150 ms 🟥 3,320 ms ↑ +6 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 105 KiB 🟥 Potential savings of 105 KiB ↑ +50 %
Lighthouse Server Backend Latencies 🟩 200 ms 🟩 70 ms ↓ −63 %
Lighthouse Initial server response time was short 🟩 Root document took 380 ms 🟩 Root document took 300 ms ↓ −21 %
Lighthouse Time to Interactive 🟥 16.7 s 🟥 16.8 s ↑ +0 %
Lighthouse Metrics 🟩 16696 🟩 16764 ↑ +0 %
Lighthouse Network Round Trip Times 🟩 60 ms 🟩 0 ms ↓ −97 %
Lighthouse Cumulative Layout Shift 🟩 0 🟩 0 ↓ −100 %

489 other audits are unchanged.

@BioPhoton BioPhoton requested a review from matejchalk August 6, 2024 10:57
@BioPhoton BioPhoton marked this pull request as ready for review August 6, 2024 10:57
e2e/nx-plugin-e2e/mocks/utils.ts Outdated Show resolved Hide resolved
e2e/nx-plugin-e2e/mocks/utils.ts Outdated Show resolved Hide resolved
e2e/nx-plugin-e2e/vite.config.e2e.ts Outdated Show resolved Hide resolved
packages/nx-plugin/src/index.ts Outdated Show resolved Hide resolved
e2e/nx-plugin-e2e/tests/configuration.e2e.test.ts Outdated Show resolved Hide resolved
e2e/nx-plugin-e2e/tests/configuration.e2e.test.ts Outdated Show resolved Hide resolved
e2e/nx-plugin-e2e/tests/configuration.e2e.test.ts Outdated Show resolved Hide resolved
e2e/nx-plugin-e2e/tests/configuration.e2e.test.ts Outdated Show resolved Hide resolved
testing/test-nx-utils/src/lib/utils/tree.unit.test.ts Outdated Show resolved Hide resolved
@BioPhoton BioPhoton requested a review from matejchalk August 6, 2024 13:53
@BioPhoton
Copy link
Collaborator Author

BioPhoton commented Aug 6, 2024

@matejchalk
I now added tests to check the file system.

The reason why I did not do that i previous PR's was because our generator also tried to install the packages and our e2e setup does not allow this ATM.

So now i added a flag to skip the installation of the packages.
I also added tests for the file system now as it can avoid errors with --skipInstall and the info messages for the skip flags.

Have a look.

matejchalk
matejchalk previously approved these changes Aug 6, 2024
e2e/nx-plugin-e2e/tests/configuration.e2e.test.ts Outdated Show resolved Hide resolved
e2e/nx-plugin-e2e/tests/init.e2e.test.ts Outdated Show resolved Hide resolved
@BioPhoton BioPhoton merged commit 323dc4e into main Aug 6, 2024
30 checks passed
@BioPhoton BioPhoton deleted the refactor-nx-plugin-e2e branch August 6, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants