fix(plugin-js-packages): omit unspecified direct dependency

code-pushup · Apr 30, 2024 · 820c350 · 820c350
1 parent 901403a
commit 820c350
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 2 deletions.
diff --git a/packages/plugin-js-packages/src/lib/runner/audit/transform.ts b/packages/plugin-js-packages/src/lib/runner/audit/transform.ts
@@ -75,7 +75,8 @@ export function vulnerabilitiesToIssues(
         ? '**all** versions'
         : `versions **${detail.versionRange}**`;
     const directDependency =
-      typeof detail.directDependency === 'string'
+      typeof detail.directDependency === 'string' &&
+      detail.directDependency !== ''
         ? `\`${detail.directDependency}\``
         : '';
     const depHierarchy =

diff --git a/packages/plugin-js-packages/src/lib/runner/audit/transform.unit.test.ts b/packages/plugin-js-packages/src/lib/runner/audit/transform.unit.test.ts
@@ -279,12 +279,30 @@ describe('vulnerabilitiesToIssues', () => {
     ).toEqual<Issue[]>([
       expect.objectContaining({
         message: expect.stringContaining(
-          "`cypress`' dependency `@cypress/request`",
+          "`cypress`' dependency `@cypress/request` has",
         ),
       }),
     ]);
   });
 
+  it('should omit direct dependency when not provided', () => {
+    expect(
+      vulnerabilitiesToIssues(
+        [
+          {
+            name: 'semver',
+            directDependency: '',
+          },
+        ] as Vulnerability[],
+        defaultAuditLevelMapping,
+      ),
+    ).toEqual<Issue[]>([
+      expect.objectContaining({
+        message: expect.stringContaining('`semver` dependency has'),
+      }),
+    ]);
+  });
+
   it('should correctly map vulnerability level to issue severity', () => {
     expect(
       vulnerabilitiesToIssues(