Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump lru-cache version to 11.x #392

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

relu91
Copy link
Contributor

@relu91 relu91 commented Jan 17, 2025

As explained in isaacs/node-lru-cache#354 old versions of lru-cache (<= 11.0.0) caused problems with new typescript releases (5.6.x). This PR upgrades the dependency to 11.0.x.

@coveralls
Copy link

coveralls commented Jan 17, 2025

Pull Request Test Coverage Report for Build 12831590664

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.611%

Totals Coverage Status
Change from base Build 9739875916: 0.0%
Covered Lines: 2884
Relevant Lines: 3102

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12831590664

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.611%

Totals Coverage Status
Change from base Build 9739875916: 0.0%
Covered Lines: 2884
Relevant Lines: 3102

💛 - Coveralls

Copy link
Member

@JKRhb JKRhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @relu91! :)

@JKRhb JKRhb merged commit ab36dae into coapjs:master Jan 17, 2025
10 checks passed
@JKRhb
Copy link
Member

JKRhb commented Jan 18, 2025

@Apollon77 I would make a new patch release containing this fix, would that be okay for you?

@Apollon77
Copy link
Collaborator

Sure, Go ahead!

@danielpeintner
Copy link

FYI: I noticed that version 1.4.1 has been published, but it is not yet reflected on the GitHub site.
Maybe something has not being working as excepted...

grafik

@JKRhb
Copy link
Member

JKRhb commented Jan 23, 2025

FYI: I noticed that version 1.4.1 has been published, but it is not yet reflected on the GitHub site. Maybe something has not being working as excepted...

grafik

Thank you for the hint, @danielpeintner, I've created a GitHub release for the 1.4.1 tag in the meantime :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants