Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json.jinja2: Remove redundant line #2391

Merged
merged 1 commit into from
Apr 6, 2018

Conversation

Hori75
Copy link
Contributor

@Hori75 Hori75 commented Mar 31, 2018

Removes a redundant line in .ci/package.json.jinja2
Closes #2388

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

Copy link
Contributor

@saksham189 saksham189 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message is incorrect. Please read the commit guidelines. You can use the command git commit --amend to change the commit message.

@Hori75 Hori75 force-pushed the removeredundantlines branch from eaed9eb to 7def218 Compare March 31, 2018 14:51
@Hori75
Copy link
Contributor Author

Hori75 commented Mar 31, 2018

Done, commit message edited.

@saksham189
Copy link
Contributor

saksham189 commented Mar 31, 2018

No. Have you read this https://api.coala.io/en/latest/Developers/Writing_Good_Commits.html? @Hori75 Change your commit message accordingly

@Hori75 Hori75 force-pushed the removeredundantlines branch from 7def218 to 509a9e3 Compare March 31, 2018 16:01
@Hori75
Copy link
Contributor Author

Hori75 commented Mar 31, 2018

I haven't read that guide before, thanks for the guide.

Copy link
Member

@sangamcse sangamcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@saksham189 saksham189 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stellargo
Copy link
Member

ack 509a9e3

@gitmate-bot
Copy link
Collaborator

Sorry @stellargo, you do not have the necessary permission levels to perform the action.

@jayvdb
Copy link
Member

jayvdb commented Apr 6, 2018

ack 509a9e3

Removes a redundant line in .ci/package.json.jinja2

Closes coala#2388
@jayvdb
Copy link
Member

jayvdb commented Apr 6, 2018

@gitmate-bot rebase

@gitmate-bot
Copy link
Collaborator

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@gitmate-bot
Copy link
Collaborator

Automated rebase with GitMate.io was successful! 🎉

@jayvdb
Copy link
Member

jayvdb commented Apr 6, 2018

@gitmate-bot ff

@gitmate-bot
Copy link
Collaborator

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently ⚠️

@gitmate-bot
Copy link
Collaborator

Automated fastforward with GitMate.io was successful! 🎉

@gitmate-bot gitmate-bot merged commit bd8a15f into coala:master Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

package.json.jinja2: Remove redundant line
6 participants