Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cilium: add sub project voting issue #1143

Closed
wants to merge 1 commit into from
Closed

Conversation

xmulligan
Copy link
Contributor

Copy link
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nate-double-u I leave the final approval to you, since the LFX platform side might need some work.

Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edited comment to request changes below.

Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xmulligan could you refactor this into the README file -- this project has been accepted.

@xmulligan
Copy link
Contributor Author

replace by #1152

@xmulligan xmulligan closed this Jan 31, 2024
@xmulligan xmulligan deleted the patch-4 branch January 31, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants