-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[es] Enable link checking and normalize links #3223
[es] Enable link checking and normalize links #3223
Conversation
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
eaf3dfb
to
9ea9246
Compare
9ea9246
to
9f0e5f8
Compare
9f0e5f8
to
910a19b
Compare
Signed-off-by: Rodolfo Martínez Vega <[email protected]>
910a19b
to
1564c92
Compare
/cc @Okabe-Junya @electrocucaracha @krol3 @raelga |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks @ramrodo!
I'm not a reviewer for Spanish, but LGTM!
I'll leave the official approval to maintainers or reviewers from the Spanish team, thank you :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excelente! Gracias ✨
/cc @nate-double-u
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome work !!
@nate-double-u could you help me to review and merge this PR, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, I'm not sure why merging would be blocked here -- you've got two approvals from the Spanish Approvers list.
Let's see if a general approve helps get it unstuck (maybe it has to do with the .htmltest.yml file change).
LGTM
Before merging this PR, we should merge first #3221 to update ourdev-es
branch and then, submit these changes tomain
branch.Merge first #3229 to include the new term and content updated.Merge first #3231 to includedev-es
branch to main and include the latest changes.Describe your changes
Related issue number or link (ex:
resolves #issue-number
)#3190
Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.