Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[es] Enable link checking and normalize links #3223

Merged

Conversation

ramrodo
Copy link
Collaborator

@ramrodo ramrodo commented Jul 15, 2024

Before merging this PR, we should merge first #3221 to update our dev-es branch and then, submit these changes to main branch.

Merge first #3229 to include the new term and content updated.

Merge first #3231 to include dev-es branch to main and include the latest changes.

Describe your changes

Related issue number or link (ex: resolves #issue-number)

#3190

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@github-actions github-actions bot added the lang/es for Spanish label Jul 15, 2024
Copy link

netlify bot commented Jul 15, 2024

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 1564c92
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/66a121e812e8fc0008ecbd84
😎 Deploy Preview https://deploy-preview-3223--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ramrodo ramrodo force-pushed the ramrodo-im-link-normalization-2024-07-15 branch 2 times, most recently from eaf3dfb to 9ea9246 Compare July 17, 2024 23:19
@ramrodo ramrodo changed the base branch from dev-es to main July 17, 2024 23:21
@ramrodo ramrodo force-pushed the ramrodo-im-link-normalization-2024-07-15 branch from 9ea9246 to 9f0e5f8 Compare July 17, 2024 23:23
@ramrodo ramrodo force-pushed the ramrodo-im-link-normalization-2024-07-15 branch from 9f0e5f8 to 910a19b Compare July 24, 2024 15:43
Signed-off-by: Rodolfo Martínez Vega <[email protected]>
@ramrodo ramrodo force-pushed the ramrodo-im-link-normalization-2024-07-15 branch from 910a19b to 1564c92 Compare July 24, 2024 15:46
@ramrodo ramrodo changed the title WIP: [es] Enable link checking, normalize links, update terms WIP: [es] Enable link checking and normalize links Jul 24, 2024
@ramrodo ramrodo marked this pull request as ready for review July 24, 2024 15:56
@ramrodo ramrodo changed the title WIP: [es] Enable link checking and normalize links [es] Enable link checking and normalize links Jul 24, 2024
@ramrodo
Copy link
Collaborator Author

ramrodo commented Jul 24, 2024

/cc @Okabe-Junya @electrocucaracha @krol3 @raelga
Could you please take a look at this PR?

Copy link
Collaborator

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks @ramrodo!

I'm not a reviewer for Spanish, but LGTM!
I'll leave the official approval to maintainers or reviewers from the Spanish team, thank you :)

@Okabe-Junya Okabe-Junya added the maintainers Use this label if PR requires maintainers to take action label Jul 24, 2024
Copy link
Collaborator

@electrocucaracha electrocucaracha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excelente! Gracias ✨

/cc @nate-double-u

@jossemarGT
Copy link
Contributor

/lgtm

Copy link
Collaborator

@krol3 krol3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work !!

@ramrodo
Copy link
Collaborator Author

ramrodo commented Aug 6, 2024

@nate-double-u could you help me to review and merge this PR, please?

Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I'm not sure why merging would be blocked here -- you've got two approvals from the Spanish Approvers list.

Let's see if a general approve helps get it unstuck (maybe it has to do with the .htmltest.yml file change).

LGTM

@nate-double-u nate-double-u merged commit a6354a5 into cncf:main Aug 6, 2024
8 checks passed
@ramrodo ramrodo deleted the ramrodo-im-link-normalization-2024-07-15 branch August 7, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/es for Spanish maintainers Use this label if PR requires maintainers to take action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants