sidecar-container.md created #3173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fernando Harris <[email protected]>
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Fernando Harris Francisco <[email protected]>
fharris
requested review from
caniszczyk,
seokho-son,
iamNoah1,
jihoon-seo,
nate-double-u and
castrojo
as code owners
Okabe-Junya
reviewed
Jun 3, 2024
There was a problem hiding this comment.
I am not a reviewer, but I will leave a nit comment, Thank you :)
ref. #2958 (comment)
Co-authored-by: Junya Okabe <[email protected]> Signed-off-by: Fernando Harris Francisco <[email protected]>
Signed-off-by: Fernando Harris Francisco <[email protected]>
|
Closing this pr and creating a new one (#3192) to solve the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Created sidecar-container.md. New Term
Related issue number or link (ex:
resolves #issue-number)resolves #2958
Checklist before opening this PR (put
xin the checkboxes)git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfigby runninggit config --global alias.ci "commit -s".