-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix for nhsn doc #1581
base: dev
Are you sure you want to change the base?
Hotfix for nhsn doc #1581
Conversation
Maybe this is considered a hotfix and should be merged directly to |
The name in the Data Sources and Signals menu is also wrong- can we change from "NHSN ED Visits" to "NHSN Hospital Respiratory Data" before merging? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏄♀️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should not merge this directly into the main
branch, as there could be a number of unintended consequences. lets merge into dev
instead and then go through a regular release process later.
parent: Data Sources and Signals | ||
grand_parent: Main Endpoint (COVIDcast) | ||
nav_order: 1 | ||
--- | ||
# National Syndromic Surveillance Program Emergency Department Visits | ||
# National Healthcare Safety Network Respiratory Hospitalizations (Continuation of [HHS]((see [date format docs](../hhs.md))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i dont know if i would put this here. first, its a little weird to have a link in the title heading. second, it could be misleading because the document uses "HHS" in a different context (for geographic regions), and this would be better mentioned with a little more detail in the "Overview" and/or "Limitations" sections. neither is "wrong"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the ticket mentioned that we should say more prominently that this data source is the continuation of the old HHS source. @carlynvandyke thoughts? maybe put it in the overview?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think George's comment makes sense. I'm going to draft some language to put in the overview.
The base branch was changed.
|
addresses #1579
Summary:
New NHSN doc page was titled with NSSP info.
Prerequisites:
dev
branchdev