Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated pkg_resources #1363

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Replace deprecated pkg_resources #1363

merged 1 commit into from
Jan 24, 2024

Conversation

rzats
Copy link
Contributor

@rzats rzats commented Jan 4, 2024 •
edited
Loading

Closes #1301.

Summary:

Removes uses of setuptools' deprecated pkg_resources library - these are replaced by the native importlib.metadata library.

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rzats rzats requested a review from melange396 January 4, 2024 16:00
melange396
melange396 approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@melange396 melange396 merged commit db08c65 into dev Jan 24, 2024
7 checks passed
@melange396 melange396 deleted the rzatserkovnyi/pkg-resources branch January 24, 2024 19:50
@melange396 melange396 mentioned this pull request Jan 30, 2024
Merged
This was referenced May 9, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melange396 melange396 melange396 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

replace deprecated pkg_resources
2 participants
@rzats @melange396