Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deprecated epidata packages #1362

Closed
wants to merge 1 commit into from
Closed

Update deprecated epidata packages #1362

wants to merge 1 commit into from
+6 −6

Conversation

rzats
Copy link
Contributor

@rzats rzats commented Jan 3, 2024

Closes #1355 & #1301.

Summary:

Updates the packages used for MySQL connectors & replaces Setuptools pkg_resources with the native importlib.metadata.

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 3, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rzats
Copy link
Contributor Author

rzats commented Jan 3, 2024

/run performance test

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024

✅ Performance tests complete! Result summary:

  • Total requests: 1000
  • Total failures: 11
  • Min response time: 9.07 ms
  • Max response time: 128984.34 ms
  • Average response time: 1221.99 ms
  • Median response time: 390.00 ms
  • Requests per second: 3.11

Click here to view full results: https://github.com/cmu-delphi/delphi-epidata/actions/runs/7399628024.

melange396
melange396 requested changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should really be split into separate PRs... can you remove this one and create two new ones?

@rzats rzats closed this Jan 4, 2024
@rzats rzats mentioned this pull request Jan 4, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melange396 melange396 melange396 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update database drivers
2 participants
@rzats @melange396