Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

track covariance Pos-def in packedcandidate #40526

Closed

Conversation

vlimant
Copy link
Contributor

@vlimant vlimant commented Jan 16, 2023

PR description:

as requested in #39599 (comment)

PR validation:

no standard workflow involves a call to this function.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 16, 2023

A new Pull Request was created by @vlimant (vlimant) for CMSSW_10_6_X.

It involves the following packages:

  • DataFormats/PatCandidates (xpog, reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo, @swertz, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc, @missirol, @gouskos, @rovere, @hatakeyamak this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Jan 16, 2023

type tracking

@mmusich
Copy link
Contributor

mmusich commented Jan 16, 2023

@cmsbuild, please test

@mmusich
Copy link
Contributor

mmusich commented Jan 16, 2023

backport of #39599

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e48d11/30001/summary.html
COMMIT: 359a707
CMSSW: CMSSW_10_6_X_2023-01-15-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40526/30001/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215349
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 143 log files, 102 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Jan 18, 2023

Dear @vlimant, yesterday at the ORP meeting it was requested to reduce the spurious changes in this PR coming from code-formatting in order to facilitate the review. I prepared a branch that merges in 10_6_X with the bare minimum of changes: https://github.com/cms-sw/cmssw/compare/CMSSW_10_6_X...mmusich:cmssw:posDef_trackcov_unpacking_10_6_X?expand=1. Please let me know if you prefer to reduce the changes in this PR, or shall I open another one instead.

@vlimant vlimant closed this Jan 18, 2023
@vlimant vlimant deleted the pseudoPosDefTrack_10_6_X branch June 5, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants