[BuildRules] Use hipcc to link product which has hip.cc sources #8274
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_13_0_X/master. @cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks. |
|
please test with cms-sw/cmssw#40619 |
|
Pull request #8274 was updated. |
|
please test with cms-sw/cmssw#40605 |
|
@smuzaffar I found the next problem with the HIPCC linking: it looks like some input files are listed twice, resulting in "duplicate symbol" errors. For example, when linking
If I remove it the duplicate entry, I move on to the next error The reason seems that the then the same linker command works. |
|
@fwyzard , cms-sw/cmssw#40605 and cms-sw/cmssw#40619 works with latest build rules. I can not build cms-sw/cmssw#40637 do I need any other Pr to go with it? |
|
Yes, cms-sw/cmssw#40637 needs cms-sw/cmssw#40619 . |
|
@fwyzard , issue with duplicate obj file is fixed ( scram was added the hip.cc file twice as it was match by both can you please try cmssw-config tag V07-05-02 ? This should fix the issue with duplicate objs and rocm.a build order |
|
Thanks, I'll check it. |
|
Pull request #8274 was updated. |
|
OK, finally this seems to be working: |
|
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1e4b84/30259/summary.html External BuildI found compilation error when building: ERROR: no such package '@tf_runtime//': java.io.IOException: Error downloading [http://mirror.tensorflow.org/github.com/tensorflow/runtime/archive/b570a1921c9e55ac53c8972bd2bfd37cd0eb510d.tar.gz, https://github.com/tensorflow/runtime/archive/b570a1921c9e55ac53c8972bd2bfd37cd0eb510d.tar.gz] to /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/tensorflow-sources/2.6.4-9f1be03565af434ebe39d0eacdd0154e/build/5f8913d9a58ba3308d4327e8feaa665f/external/tf_runtime/temp577731506896425596/b570a1921c9e55ac53c8972bd2bfd37cd0eb510d.tar.gz: Checksum was 653f631e961a0e885e5ee805d65cd6409350759ab1d7145aed9b89123b760e19 but wanted 01295fc2a90aa2d665890adbe8701e2ae2372028d3b8266cba38ceddccb42af6 INFO: Elapsed time: 5.668s INFO: 0 processes. FAILED: Build did NOT complete successfully (0 packages loaded) FAILED: Build did NOT complete successfully (0 packages loaded) error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.FcV6Xb (%build) RPM build errors: line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: external+tensorflow-sources+2.6.4-9f1be03565af434ebe39d0eacdd0154e Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.FcV6Xb (%build) |
|
wtf |
|
please test with #8273,cms-sw/cmssw#40619,cms-sw/cmssw#40637,cms-sw/cmssw#40605 |
|
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1e4b84/30262/summary.html External BuildI found compilation error when building: ERROR: no such package '@tf_runtime//': java.io.IOException: Error downloading [http://mirror.tensorflow.org/github.com/tensorflow/runtime/archive/b570a1921c9e55ac53c8972bd2bfd37cd0eb510d.tar.gz, https://github.com/tensorflow/runtime/archive/b570a1921c9e55ac53c8972bd2bfd37cd0eb510d.tar.gz] to /pool/condor/dir_43994/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/tensorflow-sources/2.6.4-9f1be03565af434ebe39d0eacdd0154e/build/e36e10f9b432475838502db74c081938/external/tf_runtime/temp8131256082103605744/b570a1921c9e55ac53c8972bd2bfd37cd0eb510d.tar.gz: Checksum was 653f631e961a0e885e5ee805d65cd6409350759ab1d7145aed9b89123b760e19 but wanted 01295fc2a90aa2d665890adbe8701e2ae2372028d3b8266cba38ceddccb42af6 INFO: Elapsed time: 3.681s INFO: 0 processes. FAILED: Build did NOT complete successfully (0 packages loaded) FAILED: Build did NOT complete successfully (0 packages loaded) error: Bad exit status from /pool/condor/dir_43994/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.krj0o0 (%build) RPM build errors: line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: external+tensorflow-sources+2.6.4-9f1be03565af434ebe39d0eacdd0154e Bad exit status from /pool/condor/dir_43994/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.krj0o0 (%build) |
|
test parameters:
|
|
please test |
|
+externals |
cmsbuild
added
externals-approved
fully-signed
and removed
externals-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_0_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
-1 Failed Tests: UnitTests Unit TestsI found errors in the following unit tests: ---> test test-das-selected-lumis had ERRORS Comparison SummarySummary:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hit.ccfilesfile="*.cc *.hip.cc"can have duplicatehip.ccfiles (once matched due to*.ccand one due to*.hip.cc)_rocm.abuild order