Bootstrap #4
Draft
Bootstrap #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be interested in bootstrap too, also without animations. Does the PR look go to you @cmer so it can be merged? |
cmer
reviewed
Apr 1, 2024
| request: nil, title: nil | ||
| request: nil, | ||
| title: nil, | ||
| bootstrap_modal_size: UltimateTurboModal.configuration.bootstrap_modal_size |
There was a problem hiding this comment.
This should not be on the base class if it's meant for the Bootstrap variant only. Should be in the Bootstrap subclass.
cmer
reviewed
Apr 1, 2024
| @@ -33,9 +36,11 @@ def initialize( | |||
| @footer_divider = footer_divider | |||
| @header = header | |||
| @header_divider = header_divider | |||
| @title_tag = title_tag | |||
There was a problem hiding this comment.
Why not reuse what we already have (ie title_block)? Also, shouldn't modify the base class.
cmer
reviewed
Apr 1, 2024
| @@ -187,7 +192,7 @@ def div_title | |||
| if @title_block.present? | |||
| render @title_block | |||
| else | |||
| h3(id: "modal-title-h", class: self.class::DIV_TITLE_H_CLASSES) { @title } | |||
| send(@title_tag, id: "modal-title-h", class: self.class::DIV_TITLE_H_CLASSES) { @title } | |||
There was a problem hiding this comment.
I suggest we leave this as it was before. If the user wants to use a different tag, they can use title_block
|
I left a few comments. If we could stay closer to the current codebase without modifying the base, that'd be ideal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I need bootstrap for my current work, I started with implementing the bootstrap flovor.
I think the HTML looks okay like this, and it only usses bootstrap classes. But the transitions are still missing. I'm not sure how to implement them with the
el-transitionAPI and only bootstrap classes.Any idea how I could improve this?