Add option to set a rootUrl from an env var to support reverse proxies (see issue #11) #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If users want to self host behind an nginx reverse proxy this handles the leading proxy location.
cloudlena
force-pushed
the
main
branch
2 times, most recently
from
dc0c22d to
412bba1
Compare
|
Very interested in this feature. Thanks for your contribution. Is there anything blocking at the moment? |
Nothing on my side, this code has been in use since I raised this PR and worked fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11
Originally designed to place multiple instances of the s3 manager in Kube behind a single nginx ingress that allowed per instance password auth and management