Testing Updates #3195
Open
Testing Updates #3195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duanemay
force-pushed
the
testing-updates
branch
6 times, most recently
from
5f72b01 to
dc5fda7
Compare
Kehrlann
approved these changes
Dec 30, 2024
There was a problem hiding this comment.
I have skimmed some of the changes at random, nothing jumped out.
I have taken a closer look at the extensions ; they are still used as "old-style" JUnit rules, instead of newer @ExtendWith. I think it's fine, might be worth changing in the future if we do more work on the integration tests themselves. Of all the extensions, the ScreenshotOnFailExtension one can be more easily changed to be @ExtendWith(ScreenshotOnFailExtension.class).
There is a comment that seems off in the ServerRunningExtension though.
server/src/test/java/org/cloudfoundry/identity/uaa/ServerRunningExtension.java
Outdated
Show resolved
Hide resolved
uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/util/ScreenshotOnFailExtension.java
Outdated
Show resolved
Hide resolved
# Conflicts: # server/src/test/java/org/cloudfoundry/identity/uaa/db/DbMigrationIntegrationTestParent.java # server/src/test/java/org/cloudfoundry/identity/uaa/db/HsqlDbMigrationIntegrationTest.java # server/src/test/java/org/cloudfoundry/identity/uaa/db/MySqlDbMigrationIntegrationTest.java # server/src/test/java/org/cloudfoundry/identity/uaa/db/PostgresDbMigrationIntegrationTest.java # server/src/test/java/org/cloudfoundry/identity/uaa/db/TableAndColumnNormalizationTest.java
# Conflicts: # uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/feature/LdapLoginIT.java # uaa/src/test/java/org/cloudfoundry/identity/uaa/mock/providers/IdentityProviderEndpointsMockMvcTests.java # Conflicts: # uaa/src/test/java/org/cloudfoundry/identity/uaa/mock/audit/AuditCheckMockMvcTests.java
Remove @ExtendWith(SpringExtension.class) and @ContextConfiguration in favor of @SpringJUnitConfig
duanemay
force-pushed
the
testing-updates
branch
from
dc5fda7 to
0746985
Compare
duanemay
force-pushed
the
testing-updates
branch
from
0746985 to
5e1c30c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to provide more consistency in our test suites, standardizing on Junit5 and AssetJ.
We have had a mix of Junit 4 and 5 annotations, and a mix of Junit, Hamcrest, and AssertJ asserts, and various hamcrest matchers.
The Junit Annotations have all been moved to v5. Junit Rules have been migrated to Extensions. There remain places where Junit 4 support code is used notably in Extensions, e.g. OAuth2ContextExtension.
Hamcrest Matchers are still used in the production code and a few places in the tests.