This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
Support multicontainer pods for status and crash reports #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/169883480 The labels on this github issue will be updated when the story is started. |
[#169685576] Co-authored-by: Tim Downey <[email protected]>
mike1808
force-pushed
the
pods-status-multicontainer
branch
from
76c4d52 to
1a3294a
Compare
|
Thanks for contributing @mike1808. LGTM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress towards #79
We changed the way we determine whether the pod is crashed or running by checking the status of all containers on the pod, not only the first one. This required when we inject sidecars into pods.
#169685576
cc @rosenhouse @tcdowney