Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cf revision command implementation [main] #3341

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

gururajsh
Copy link
Member

This PR implements the revision command which the revision details of an app when given a revision version. The revision command is no longer experimental.

Copy link

linux-foundation-easycla bot commented Dec 20, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Co-authored-by: Lisa Burns <[email protected]>
Signed-off-by: Steve Taylor <[email protected]>

Update help info related to revision command

Return error when no app/revision is present
Copy link
Contributor

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good in general, added a nit and a couple of questions that we should get answered before merging

command/v7/revision_command.go Outdated Show resolved Hide resolved
command/v7/revision_command.go Outdated Show resolved Hide resolved
command/v7/revision_command.go Show resolved Hide resolved
Copy link
Member

@a-b a-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gururajsh gururajsh merged commit 61197b9 into cloudfoundry:main Jan 6, 2025
17 of 19 checks passed
@gururajsh gururajsh deleted the revision-test-main branch January 6, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants