[main] Make retrieval of tasks in bulk instead of small increments #3275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-b
approved these changes
Nov 1, 2024
Signed-off-by: João Pereira <[email protected]>
- Fix issue, where code was always doing 2 requests even when it was able to get all the tasks in the first request Signed-off-by: João Pereira <[email protected]>
joaopapereira
force-pushed
the
bulk-retrieval-of-tasks
branch
from
6a3e72e to
adb2258
Compare
Signed-off-by: João Pereira <[email protected]>
Signed-off-by: João Pereira <[email protected]>
Signed-off-by: João Pereira <[email protected]>
Signed-off-by: João Pereira <[email protected]>
gururajsh
pushed a commit
to gururajsh/cli
that referenced
this pull request
Dec 12, 2024
…loudfoundry#3275) * Make retrieval of tasks in bulk instead of small increments Signed-off-by: João Pereira <[email protected]> * Address PR comments - Fix issue, where code was always doing 2 requests even when it was able to get all the tasks in the first request Signed-off-by: João Pereira <[email protected]> * Fix lack of output Signed-off-by: João Pereira <[email protected]> * Remove extra tasks from first request Signed-off-by: João Pereira <[email protected]> * Hardcode version because no tag exists for main branch Signed-off-by: João Pereira <[email protected]> * Change approach by providing the query parameters always to the request Signed-off-by: João Pereira <[email protected]> --------- Signed-off-by: João Pereira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
In this PR we change the way tasks are retrieved in CLI to lower the load that it currently has in CAPI when there are a big number of tasks associated with a particular application
Related to #3274