Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add DiskIDTransform Rules #403

Merged
merged 13 commits into from
Jan 16, 2025
Merged

add DiskIDTransform Rules #403

merged 13 commits into from
Jan 16, 2025

Conversation

ramonskie
Copy link
Contributor

this will add the diskid transform rules needed for cloudfoundry/bosh-agent#343

jpalermo
jpalermo previously approved these changes Dec 20, 2024
View reviewed changes
@ramonskie ramonskie requested review from a team, mvach and nouseforaname and removed request for a team and nouseforaname December 21, 2024 12:35
rkoster
rkoster requested changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@rkoster rkoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed during Working group call, could you add a bit of documentation so that further people know what the paths where that we want to match against.

@beyhan beyhan merged commit d75f7f5 into ubuntu-noble Jan 16, 2025
1 check passed
@beyhan beyhan deleted the noble-agent-diskid branch January 16, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmoehler fmoehler fmoehler approved these changes

@benjaminguttmann-avtq benjaminguttmann-avtq benjaminguttmann-avtq left review comments

@jpalermo jpalermo jpalermo left review comments

@rkoster rkoster rkoster requested changes

@beyhan beyhan beyhan approved these changes

@mvach mvach Awaiting requested review from mvach mvach was automatically assigned from cloudfoundry/wg-foundational-infrastructure-vm-deployment-lifecycle-bosh-approvers

Assignees
No one assigned
Labels
None yet
Projects
Foundational Infrastructure Working Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ramonskie @jpalermo @rkoster @beyhan @benjaminguttmann-avtq @fmoehler