Fix installing Wrangler using pnpm

[Leetfs]

issue: #338

test url: https://github.com/Leetfs-dev/test/actions/runs/12271068666/job/34238417617

dependencies:
  + pnpm 9.13.2 (9.15.0 is available)

Run Leetfs/wrangler-action@v1
🔍 Checking for existing Wrangler installation
📥 Installing Wrangler
🚀 Running Wrangler Commands
🏁 Wrangler Action completed

[Leetfs]

@Maximo-Guk

Hi, could you please take a look at this PR when you have time? It's been pending for a while. Let me know if any changes are needed. Thanks.

[Maximo-Guk]

Hi @Leetfs 👋, sorry for taking so long to respond!

I'm not sure if it's common for GitHub actions to install packages to the global scope, since it seems to me that now our action might be introducing some unintended side effects.

I think I would recommend users to instead use the official pnpm action https://github.com/pnpm/action-setup, and then invoke wrangler-action with your globally installed package.

What do you think?

[Leetfs]

Hi @Maximo-Guk , thanks for your reply

I retested the workflow, using pnpm/[email protected] and cloudflare/[email protected]

Please note:

• pnpm does not allow adding dependencies directly to the workspace root directory by default
• Need to use -g -w parameters to explicitly specify the installation location

I think it will be more convenient to install wrangler to the global path in the workflow, so use the -g parameter.

[Maximo-Guk]

@Leetfs Are you able to install wrangler in the root package.json of your project? https://github.com/mtftm/test/blob/main/package.json#L14

"devDependencies": {
     ...
     "wrangler": "latest" // or pin the version, if you'd like
     ...
}

If you have wrangler specified in your root package.json, it should become available to the action as well, meaning you wouldn't even need to add wrangler to the global scope

[Leetfs]

@Maximo-Guk Sure ~ but I still recommend fixing this.

Perhaps I would suggest using the -w flag instead of modifying the package.json.

This might confuse developers who haven't specified wrangler in their package.json, as the workflow already includes a step to install wrangler.

Additionally, there are the following reasons:

• The current behavior of pnpm is inconsistent with other package managers.
• For example, the same project might work with npm but not with pnpm.
• If wrangler is directly specified in package.json, then the automatic installation of wrangler by the wrangler-action becomes moot, which doesn't seem to be the intended behavior.

In summary, it is recommended to modify the installation command in response to the pnpm error.

Thank you for your attention.

[Maximo-Guk]

I believe -w flag only works when you're inside of a pnpm workspace.

I definitely think we should document this better, and urge users to specify wrangler in their package.json if they're using a pnpm workspace

[Leetfs]

@Maximo-Guk Okay~Thank you for your attention to this PR.