Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vite-plugin] use the new resolve.builtins vite config to specify the cloudflare builtins #8104

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dario-piotrowicz
Copy link
Member

Closes flarelabs-net/vite-plugin-cloudflare#52

Note: in flarelabs-net/vite-plugin-cloudflare#52 I've done some extra work to also conditionally include/exclude the nodejs externals based on the nodejs_compat flag, I am happy to do that here as well but I figured that maybe it'd be cleaner to do one thing at a time, and first simply use the new resolve.builtins option before optimizing further


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: the module resolution is already tested
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: unrelated to wrangler
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal change, no user facing changes

@dario-piotrowicz dario-piotrowicz requested review from a team as code owners February 11, 2025 23:34
Copy link

changeset-bot bot commented Feb 11, 2025

⚠️ No Changeset found

Latest commit: 3ce2e36

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 11, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13334080688/npm-package-wrangler-8104

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8104/npm-package-wrangler-8104

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13334080688/npm-package-wrangler-8104 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13334080688/npm-package-cloudflare-workers-bindings-extension-8104 -O ./cloudflare-workers-bindings-extension.0.0.0-vf8981785a.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vf8981785a.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13334080688/npm-package-create-cloudflare-8104 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13334080688/npm-package-cloudflare-kv-asset-handler-8104

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13334080688/npm-package-miniflare-8104

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13334080688/npm-package-cloudflare-pages-shared-8104

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13334080688/npm-package-cloudflare-unenv-preset-8104

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13334080688/npm-package-cloudflare-vite-plugin-8104

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13334080688/npm-package-cloudflare-vitest-pool-workers-8104

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13334080688/npm-package-cloudflare-workers-editor-shared-8104

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13334080688/npm-package-cloudflare-workers-shared-8104

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13334080688/npm-package-cloudflare-workflows-shared-8104

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250204.1
workerd 1.20250204.0 1.20250204.0
workerd --version 1.20250204.0 2025-02-04

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@dario-piotrowicz dario-piotrowicz added the vite-plugin Relating to the `@cloudflare/vite-plugin` package label Feb 12, 2025
@petebacondarwin petebacondarwin force-pushed the dario/vite-plugin/cloudflare-builtins branch from 6b2b51d to 7cab026 Compare February 14, 2025 11:07
@petebacondarwin
Copy link
Contributor

Rebased to see if this still works with the changes I made to nodejs compat

packages/vite-plugin-cloudflare/src/miniflare-options.ts Outdated Show resolved Hide resolved
// Worker modules (CompiledWasm, Text, Data)
moduleRE.test(moduleId) ||
// Node.js builtin node modules (they will be resolved to unenv aliases)
nodeBuiltInModules.has(moduleId);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Know we've discussed it before but it still doesn't really make sense to me that we have to externalize things again here. Agree this is correct for now though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I 100% totally agree 👍

I'll go and investigate this 👍 (but yeah for this PR I would keep it as is since this is also effects the other modules)

@dario-piotrowicz dario-piotrowicz requested review from a team as code owners February 14, 2025 17:12
@dario-piotrowicz dario-piotrowicz force-pushed the dario/vite-plugin/cloudflare-builtins branch from 8baebf4 to 8affca1 Compare February 14, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changeset-required vite-plugin Relating to the `@cloudflare/vite-plugin` package
Projects
Status: Approved
Development

Successfully merging this pull request may close these issues.

3 participants