-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wrangler] fix: avoid getPlatformProxy
logging twice that it is using vars defined in .dev.vars
files
#7947
[wrangler] fix: avoid getPlatformProxy
logging twice that it is using vars defined in .dev.vars
files
#7947
Conversation
🦋 Changeset detectedLatest commit: aec0e24 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13019696632/npm-package-wrangler-7947 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7947/npm-package-wrangler-7947 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13019696632/npm-package-wrangler-7947 dev path/to/script.js Additional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13019696632/npm-package-cloudflare-workers-bindings-extension-7947 -O ./cloudflare-workers-bindings-extension.0.0.0-vdc1547143.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vdc1547143.vsix create-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13019696632/npm-package-create-cloudflare-7947 --no-auto-update @cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13019696632/npm-package-cloudflare-kv-asset-handler-7947 miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13019696632/npm-package-miniflare-7947 @cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13019696632/npm-package-cloudflare-pages-shared-7947 @cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13019696632/npm-package-cloudflare-unenv-preset-7947 @cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13019696632/npm-package-cloudflare-vite-plugin-7947 @cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13019696632/npm-package-cloudflare-vitest-pool-workers-7947 @cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13019696632/npm-package-cloudflare-workers-editor-shared-7947 @cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13019696632/npm-package-cloudflare-workers-shared-7947 @cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13019696632/npm-package-cloudflare-workflows-shared-7947 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
…ng vars defined in `.dev.vars` files when `getPlatformProxy` is called and it retrieves values from `.dev.vars` files, it logs twice a message like: `Using vars defined in .dev.vars`, the changes here make sure that in such cases this log only appears once
5f9463c
to
aec0e24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The point being that getMiniflareOptionsFromConfig()
now also reads the .dev.vars
so there is no need to do it again in getPlatformProxy()
?
yes, exactly 🙂👍 |
Fixes #7944
when
getPlatformProxy
is called and it retrieves values from.dev.vars
files, it logs twice a message like:Using vars defined in .dev.vars
, the changes here make sure that in such cases this log only appears once(Prerequisite for fixing opennextjs/opennextjs-cloudflare#288)