Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse CI jobs into one #7937

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Collapse CI jobs into one #7937

merged 2 commits into from
Jan 28, 2025

Conversation

penalosa
Copy link
Contributor

Previously we run packages and fixtures as different CI jobs. This meant that we were wasting on average 30s-1m30s building and setting up runners (in particular, pnpm install takes a long time even with a warm cache).

This PR changes it to make packages and fixtures run in the same job, reducing wasted setup time.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: tooling change
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: tooling change
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: tooling change

@penalosa penalosa requested a review from a team as a code owner January 28, 2025 15:09
Copy link

changeset-bot bot commented Jan 28, 2025

⚠️ No Changeset found

Latest commit: 1c5cc7b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 28, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13016308660/npm-package-wrangler-7937

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7937/npm-package-wrangler-7937

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13016308660/npm-package-wrangler-7937 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13016308660/npm-package-cloudflare-workers-bindings-extension-7937 -O ./cloudflare-workers-bindings-extension.0.0.0-vf76bf5bb8.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vf76bf5bb8.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13016308660/npm-package-create-cloudflare-7937 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13016308660/npm-package-cloudflare-kv-asset-handler-7937

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13016308660/npm-package-miniflare-7937

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13016308660/npm-package-cloudflare-pages-shared-7937

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13016308660/npm-package-cloudflare-unenv-preset-7937

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13016308660/npm-package-cloudflare-vite-plugin-7937

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13016308660/npm-package-cloudflare-vitest-pool-workers-7937

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13016308660/npm-package-cloudflare-workers-editor-shared-7937

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13016308660/npm-package-cloudflare-workers-shared-7937

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13016308660/npm-package-cloudflare-workflows-shared-7937

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250124.0
workerd 1.20250124.0 1.20250124.0
workerd --version 1.20250124.0 2025-01-24

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa penalosa merged commit 12675cc into main Jan 28, 2025
26 checks passed
@penalosa penalosa deleted the penalosa-patch-10 branch January 28, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants