Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: don't fail the PR description check for draft PRs #7930

Merged

Conversation

petebacondarwin
Copy link
Contributor

@petebacondarwin petebacondarwin commented Jan 28, 2025

Fixes #0000

Changes the PR description validation so that it only "fails" the CI check if the PR is "ready for review" (i.e. not in draft).


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: it is a change to a test
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: not applicable
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: not a documented feature

Copy link

changeset-bot bot commented Jan 28, 2025

⚠️ No Changeset found

Latest commit: f587299

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@petebacondarwin petebacondarwin force-pushed the pbd/only-fail-description-checks-when-not-draft branch from 86e4aec to a3177fc Compare January 28, 2025 10:38
Copy link
Contributor

github-actions bot commented Jan 28, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13011742384/npm-package-wrangler-7930

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7930/npm-package-wrangler-7930

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13011742384/npm-package-wrangler-7930 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13011742384/npm-package-cloudflare-workers-bindings-extension-7930 -O ./cloudflare-workers-bindings-extension.0.0.0-v01538e4a2.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v01538e4a2.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13011742384/npm-package-create-cloudflare-7930 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13011742384/npm-package-cloudflare-kv-asset-handler-7930

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13011742384/npm-package-miniflare-7930

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13011742384/npm-package-cloudflare-pages-shared-7930

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13011742384/npm-package-cloudflare-unenv-preset-7930

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13011742384/npm-package-cloudflare-vite-plugin-7930

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13011742384/npm-package-cloudflare-vitest-pool-workers-7930

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13011742384/npm-package-cloudflare-workers-editor-shared-7930

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13011742384/npm-package-cloudflare-workers-shared-7930

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13011742384/npm-package-cloudflare-workflows-shared-7930

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250124.0
workerd 1.20250124.0 1.20250124.0
workerd --version 1.20250124.0 2025-01-24

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@petebacondarwin petebacondarwin force-pushed the pbd/only-fail-description-checks-when-not-draft branch 2 times, most recently from de967c3 to 2ae22f5 Compare January 28, 2025 13:26
@petebacondarwin petebacondarwin marked this pull request as ready for review January 28, 2025 13:37
@petebacondarwin petebacondarwin requested a review from a team as a code owner January 28, 2025 13:37
@petebacondarwin petebacondarwin force-pushed the pbd/only-fail-description-checks-when-not-draft branch from 2ae22f5 to f587299 Compare January 28, 2025 13:40
@petebacondarwin petebacondarwin marked this pull request as draft January 28, 2025 13:43
@petebacondarwin petebacondarwin marked this pull request as ready for review January 28, 2025 14:09
@petebacondarwin petebacondarwin merged commit 1af92e3 into main Jan 28, 2025
37 of 41 checks passed
@petebacondarwin petebacondarwin deleted the pbd/only-fail-description-checks-when-not-draft branch January 28, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants