Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow for uploading asset-worker and router-worker #7925

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

WillTaylorDev
Copy link
Contributor

Creates internal workflow to allow us to upload new versions of router-worker and asset-worker without an explicit wrangler release.

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: n/a
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: n/a
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal workflow

@WillTaylorDev WillTaylorDev requested a review from a team as a code owner January 27, 2025 20:20
Copy link

changeset-bot bot commented Jan 27, 2025

⚠️ No Changeset found

Latest commit: 86b2fc1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 27, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017385246/npm-package-wrangler-7925

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7925/npm-package-wrangler-7925

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017385246/npm-package-wrangler-7925 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017385246/npm-package-cloudflare-workers-bindings-extension-7925 -O ./cloudflare-workers-bindings-extension.0.0.0-vaa390397c.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vaa390397c.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017385246/npm-package-create-cloudflare-7925 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017385246/npm-package-cloudflare-kv-asset-handler-7925

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017385246/npm-package-miniflare-7925

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017385246/npm-package-cloudflare-pages-shared-7925

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017385246/npm-package-cloudflare-unenv-preset-7925

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017385246/npm-package-cloudflare-vite-plugin-7925

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017385246/npm-package-cloudflare-vitest-pool-workers-7925

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017385246/npm-package-cloudflare-workers-editor-shared-7925

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017385246/npm-package-cloudflare-workers-shared-7925

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017385246/npm-package-cloudflare-workflows-shared-7925

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250124.0
workerd 1.20250124.0 1.20250124.0
workerd --version 1.20250124.0 2025-01-24

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@WillTaylorDev WillTaylorDev force-pushed the willtaylor/asset-workers-deploy-workflow branch 2 times, most recently from 4dce487 to 255814b Compare January 28, 2025 13:45
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending on an internal discussion

@WillTaylorDev WillTaylorDev force-pushed the willtaylor/asset-workers-deploy-workflow branch from 255814b to 86b2fc1 Compare January 28, 2025 18:46
Copy link
Member

@edmundhung edmundhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for posterity, this is discussed within the team and we confirmed both workers are not deployed directly to production as the deploy script is only doing a version upload.

@WillTaylorDev FYI, The changeset workflow will still upload a new version if there is any changes on @cloudflare/workers-shared. You might need to modify the setup if you don't want it.

@WillTaylorDev WillTaylorDev merged commit ea3e16a into main Jan 30, 2025
26 checks passed
@WillTaylorDev WillTaylorDev deleted the willtaylor/asset-workers-deploy-workflow branch January 30, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants