-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow for uploading asset-worker and router-worker #7925
Conversation
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017385246/npm-package-wrangler-7925 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7925/npm-package-wrangler-7925 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017385246/npm-package-wrangler-7925 dev path/to/script.js Additional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017385246/npm-package-cloudflare-workers-bindings-extension-7925 -O ./cloudflare-workers-bindings-extension.0.0.0-vaa390397c.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vaa390397c.vsix create-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017385246/npm-package-create-cloudflare-7925 --no-auto-update @cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017385246/npm-package-cloudflare-kv-asset-handler-7925 miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017385246/npm-package-miniflare-7925 @cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017385246/npm-package-cloudflare-pages-shared-7925 @cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017385246/npm-package-cloudflare-unenv-preset-7925 @cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017385246/npm-package-cloudflare-vite-plugin-7925 @cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017385246/npm-package-cloudflare-vitest-pool-workers-7925 @cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017385246/npm-package-cloudflare-workers-editor-shared-7925 @cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017385246/npm-package-cloudflare-workers-shared-7925 @cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017385246/npm-package-cloudflare-workflows-shared-7925 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
4dce487
to
255814b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pending on an internal discussion
255814b
to
86b2fc1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for posterity, this is discussed within the team and we confirmed both workers are not deployed directly to production as the deploy script is only doing a version upload.
@WillTaylorDev FYI, The changeset workflow will still upload a new version if there is any changes on @cloudflare/workers-shared
. You might need to modify the setup if you don't want it.
Creates internal workflow to allow us to upload new versions of router-worker and asset-worker without an explicit wrangler release.