feat: add provisioning to versions upload and reprovision on bucket jurisdiction changes #7889

emily-shen · 2025-01-23T22:47:01Z

Allows resource provisioning in versions upload.
Also allow switching jurisdictions (since apparently buckets with the same name can exist in different jurisdictions).

Tests
- TODO (before merge)
- Tests included
- Tests not necessary because:
E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
- I don't know
- Required
- Not required because:
Public documentation
- TODO (before merge)
- Cloudflare docs PR(s):
- Documentation not necessary because: experimental feature

changeset-bot · 2025-01-23T22:47:05Z

🦋 Changeset detected

Latest commit: 0e311e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
wrangler	Patch
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2025-01-23T23:07:12Z

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13032244342/npm-package-wrangler-7889

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7889/npm-package-wrangler-7889

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13032244342/npm-package-wrangler-7889 dev path/to/script.js

Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13032244342/npm-package-cloudflare-workers-bindings-extension-7889 -O ./cloudflare-workers-bindings-extension.0.0.0-vd11e670fb.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vd11e670fb.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13032244342/npm-package-create-cloudflare-7889 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13032244342/npm-package-cloudflare-kv-asset-handler-7889

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13032244342/npm-package-miniflare-7889

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13032244342/npm-package-cloudflare-pages-shared-7889

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13032244342/npm-package-cloudflare-unenv-preset-7889

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13032244342/npm-package-cloudflare-vite-plugin-7889

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13032244342/npm-package-cloudflare-vitest-pool-workers-7889

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13032244342/npm-package-cloudflare-workers-editor-shared-7889

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13032244342/npm-package-cloudflare-workers-shared-7889

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13032244342/npm-package-cloudflare-workflows-shared-7889

Note that these links will no longer work once the GitHub Actions artifact expires.

[email protected] includes the following runtime dependencies:

Package	Constraint	Resolved
`miniflare`	workspace:*	3.20250124.0
`workerd`	1.20250124.0	1.20250124.0
`workerd --version`	1.20250124.0	2025-01-24

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

fixtures/worker-ts/wrangler.toml

emily-shen · 2025-01-27T18:23:58Z

packages/wrangler/src/d1/utils.ts

@@ -46,7 +46,7 @@ export const getDatabaseByNameOrBinding = async (
 		return dbFromConfig;
 	}

-	const allDBs = await listDatabases(accountId);
+	const allDBs = await listDatabases(accountId, true);


Do we care that limitCalls = true changes technically breaks existing behaviour a bit? Previously this would (slowly) get all databases, now this only gets 30.
can we pass in a larger page size (it's 10 by default) - i tested it at 100 and it didn't seem to be noticably slower.

This is a bit of a hack for now. Once the new API is ready we can switch over to that, which should be today or tomorrow

Is the new API ready yet? Do we wanna wait for it or merge this as is?

It's ready now, so I'll update this PR to use it now

packages/wrangler/src/deployment-bundle/bindings.ts

edmundhung · 2025-01-28T14:01:58Z

packages/wrangler/src/__tests__/provision.test.ts

-			},
-			{ once: true }
+			}
+			// { once: true }


edmundhung

Looks good to me. Just two minor comments.

edmundhung · 2025-01-28T14:05:22Z

packages/wrangler/src/d1/utils.ts

@@ -46,7 +46,7 @@ export const getDatabaseByNameOrBinding = async (
 		return dbFromConfig;
 	}

-	const allDBs = await listDatabases(accountId);
+	const allDBs = await listDatabases(accountId, true);


Is the new API ready yet? Do we wanna wait for it or merge this as is?

edmundhung · 2025-01-28T14:27:53Z

packages/wrangler/src/versions/upload.ts

+			getFlag("RESOURCES_PROVISION")
+				? await provisionBindings(
+						bindings,
+						accountId,
+						scriptName,
+						props.experimentalAutoCreate,
+						props.config
+					)
+				: null;


Nit: Just find the syntax a little bit strange 😅

Suggested change

getFlag("RESOURCES_PROVISION")

? await provisionBindings(

bindings,

accountId,

scriptName,

props.experimentalAutoCreate,

props.config

)

: null;

if (getFlag("RESOURCES_PROVISION")) {

await provisionBindings(

bindings,

accountId,

scriptName,

props.experimentalAutoCreate,

props.config

);

}

edmundhung · 2025-01-29T12:08:46Z

.changeset/neat-sloths-reply.md

+"wrangler": patch
+---
+
+feat: add resource auto-provisioning to versions upload


Should we make it clear that this is still experimental and requires an experimental flag

emily-shen requested a review from a team as a code owner January 23, 2025 22:47

workers-devprod added the e2e Run wrangler e2e tests on a PR label Jan 23, 2025

emily-shen requested a review from a team as a code owner January 24, 2025 01:14

penalosa force-pushed the emily/provisioning-versions-upload branch from 21a58b5 to 774721e Compare January 24, 2025 15:21

emily-shen commented Jan 27, 2025

View reviewed changes

emily-shen changed the title ~~feat: add provisioning to versions upload~~ feat: add provisioning to versions upload and reprovision on bucket jurisdiction changes Jan 27, 2025

edmundhung reviewed Jan 28, 2025

View reviewed changes

edmundhung approved these changes Jan 28, 2025

View reviewed changes

emily-shen and others added 10 commits January 28, 2025 18:17

add provisioning to versions upload

a7f2f8a

changeset

14df701

bucket stuff

455e48a

refactor and add tests

4b3779c

Fix snapshots

e917195

remove stray DB

15e1b1c

add more comments

c2b2a1b

correct comment

c215547

Update provision.test.ts

f4eb2e9

Use new D1 API

04f1a47

penalosa force-pushed the emily/provisioning-versions-upload branch from 87ed74f to 04f1a47 Compare January 28, 2025 18:17

lint

af76593

edmundhung reviewed Jan 29, 2025

View reviewed changes

Update neat-sloths-reply.md

0e311e4

penalosa merged commit 38db4ed into main Jan 29, 2025
28 checks passed

penalosa deleted the emily/provisioning-versions-upload branch January 29, 2025 13:44

workers-devprod mentioned this pull request Jan 29, 2025

Version Packages #7933

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add provisioning to versions upload and reprovision on bucket jurisdiction changes #7889

feat: add provisioning to versions upload and reprovision on bucket jurisdiction changes #7889

emily-shen commented Jan 23, 2025 •

edited

Loading

changeset-bot bot commented Jan 23, 2025 •

edited

Loading

github-actions bot commented Jan 23, 2025 •

edited

Loading

emily-shen Jan 27, 2025

penalosa Jan 27, 2025

edmundhung Jan 28, 2025

penalosa Jan 28, 2025

penalosa Jan 28, 2025

edmundhung Jan 28, 2025

penalosa Jan 28, 2025

edmundhung left a comment

edmundhung Jan 28, 2025

edmundhung Jan 28, 2025

penalosa Jan 28, 2025

edmundhung Jan 29, 2025 •

edited

Loading

feat: add provisioning to versions upload and reprovision on bucket jurisdiction changes #7889

feat: add provisioning to versions upload and reprovision on bucket jurisdiction changes #7889

Conversation

emily-shen commented Jan 23, 2025 • edited Loading

changeset-bot bot commented Jan 23, 2025 • edited Loading

🦋 Changeset detected

github-actions bot commented Jan 23, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

edmundhung left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

edmundhung Jan 29, 2025 • edited Loading

Choose a reason for hiding this comment

emily-shen commented Jan 23, 2025 •

edited

Loading

changeset-bot bot commented Jan 23, 2025 •

edited

Loading

github-actions bot commented Jan 23, 2025 •

edited

Loading

edmundhung Jan 29, 2025 •

edited

Loading